Issue 467453002: Take two at fixing android bots still using testlistjson.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 467453002: Take two at fixing android bots still using testlistjson. (Closed)

Created:
6 years, 4 months ago by ojan

Modified:
6 years, 4 months ago

Reviewers:
szager1

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Take two at fixing android bots still using testlistjson. testlistjson should go down the same codepath as other content that serves up the actual file content so that it gets the right master name. TBR since this is causing 500s on the live server. TBR=szager@chromium.org Revert "Get rid of testlistjson query parameter." This reverts r180005. Turns out that the android JSONResultsGenerator really does depend on testlistjson not having the results and times. :( TBR=szager@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180011

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -4 lines)			Patch
M	Tools/TestResultServer/handlers/testfilehandler.py	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	Tools/TestResultServer/handlers/testfilehandler_test.py	View	2 chunks	+13 lines, -4 lines	0 comments	Download
M	Tools/TestResultServer/model/jsonresults.py	View	1 chunk	+27 lines, -0 lines	0 comments	Download
M	Tools/TestResultServer/model/jsonresults_unittest.py	View	2 chunks	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as 180011.

Expand Messages | Collapse Messages