Defer request to print a PDF when the user initiates the entire frame and the PDF hasn't loaded.

chrome/renderer/pepper/ppb_pdf_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/pepper/ppb_pdf_impl.h"
 
 #include "base/files/scoped_file.h"
 #include "base/metrics/histogram.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 442 matching lines @@
 // static
 const PPB_PDF* PPB_PDF_Impl::GetInterface() { return &ppb_pdf; }
 
 // static
 void PPB_PDF_Impl::InvokePrintingForInstance(PP_Instance instance_id) {
 #if defined(ENABLE_FULL_PRINTING)
   blink::WebElement element = GetWebElement(instance_id);
   printing::PrintWebViewHelper* helper = GetPrintWebViewHelper(element);
   if (helper)
     helper->PrintNode(element);
+
+  // DidStopLoading() is not call anywhere. Calling it here fixes a problem
+  // where PrintWebViewHelper() is waiting for DidStopLoading to be called to
+  // progress the preview process.
+  DidStopLoading(instance_id);

[ivandavid, 2014/08/14 03:38:13]

Is this an appropriate place to place DidStopLoading()? It fixes the sheets
problem, however it might not be a good idea to put it here. I tried looking for
references to DidStartLoading, but I couldn't really find one.

[Vitaly Buka (NO REVIEWS), 2014/08/14 05:19:43]

It does not look like a right place
let's remove this and _NODE related change and fix that in a separate CL

On 2014/08/14 03:38:13, ivandavid wrote:

 #endif  // ENABLE_FULL_PRINTING
 }