Defer request to print a PDF when the user initiates the entire frame and the PDF hasn't loaded.

chrome/renderer/printing/print_web_view_helper.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_PRINTING_PRINT_WEB_VIEW_HELPER_H_
 #define CHROME_RENDERER_PRINTING_PRINT_WEB_VIEW_HELPER_H_
 
 #include <vector>
 
+#include "base/callback.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/shared_memory.h"
 #include "base/memory/weak_ptr.h"
 #include "base/time/time.h"
 #include "content/public/renderer/render_view_observer.h"
 #include "content/public/renderer/render_view_observer_tracker.h"
 #include "printing/metafile_impl.h"
 #include "third_party/WebKit/public/platform/WebCanvas.h"
 #include "third_party/WebKit/public/web/WebNode.h"
@@ skipping 434 matching lines @@
     enum PrintPreviewErrorBuckets error_;
 
     State state_;
   };
 
   bool print_node_in_progress_;
   PrintPreviewContext print_preview_context_;
   bool is_loading_;
   bool is_scripted_preview_delayed_;
   base::WeakPtrFactory<PrintWebViewHelper> weak_ptr_factory_;
+
+  // Stores the type of function that should be called when DidStopLoading() is
+  // called. This is needed due to a race condition that is caused when
+  // RequestPrintPreview is called with
+  // |PRINT_PREVIEW_USER_INITIATED_ENTIRE_FRAME| and DidStopLoading() has not
+  // yet been called. This allows the call to RequestPrintPreview to be
+  // deferred until DidStopLoading() has actually been called.
+  PrintPreviewRequestType on_stop_loading_type_;

[ivandavid, 2014/08/13 20:58:55]

I am using an enum this time because using base::Closure made the code less
readable and was overly complicated.

[Vitaly Buka (NO REVIEWS), 2014/08/13 23:39:45]

Actually I like more Closure version.

On 2014/08/13 20:58:55, ivandavid wrote:

[ivandavid, 2014/08/14 03:38:13]

Done.

[ivandavid, 2014/08/14 03:38:13]

Ok. I re-implemented it.

[ivandavid, 2014/08/14 03:38:13]

Ok. I reimplemented it.

   DISALLOW_COPY_AND_ASSIGN(PrintWebViewHelper);
 };
 
 }  // namespace printing
 
 #endif  // CHROME_RENDERER_PRINTING_PRINT_WEB_VIEW_HELPER_H_