Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1488)

Unified Diff: minidump/minidump_memory_writer_test.cc

Issue 467323003: MinidumpMemoryWriter test: Don’t suffix uint64_t constants (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_memory_writer_test.cc
diff --git a/minidump/minidump_memory_writer_test.cc b/minidump/minidump_memory_writer_test.cc
index 3015bbe62df845c680e0baff9819d31aec7f8db0..42de3ce22d4fc20fd71c9bb4ae24ea92e7d60027 100644
--- a/minidump/minidump_memory_writer_test.cc
+++ b/minidump/minidump_memory_writer_test.cc
@@ -186,7 +186,7 @@ TEST(MinidumpMemoryWriter, OneMemoryRegion) {
MinidumpFileWriter minidump_file_writer;
MinidumpMemoryListWriter memory_list_writer;
- const uint64_t kBaseAddress = 0xfedcba9876543210ull;
+ const uint64_t kBaseAddress = 0xfedcba9876543210;
const uint64_t kSize = 0x1000;
const uint8_t kValue = 'm';
@@ -222,10 +222,10 @@ TEST(MinidumpMemoryWriter, TwoMemoryRegions) {
MinidumpFileWriter minidump_file_writer;
MinidumpMemoryListWriter memory_list_writer;
- const uint64_t kBaseAddress1 = 0x00c0ffeeull;
+ const uint64_t kBaseAddress1 = 0xc0ffee;
const uint64_t kSize1 = 0x0100;
const uint8_t kValue1 = '6';
- const uint64_t kBaseAddress2 = 0xfac00facull;
+ const uint64_t kBaseAddress2 = 0xfac00fac;
const uint64_t kSize2 = 0x0200;
const uint8_t kValue2 = '!';
@@ -315,7 +315,7 @@ TEST(MinidumpMemoryWriter, ExtraMemory) {
// memory writer a child of the memory list writer.
MinidumpFileWriter minidump_file_writer;
- const uint64_t kBaseAddress1 = 0x0000000000001000ull;
+ const uint64_t kBaseAddress1 = 0x1000;
const uint64_t kSize1 = 0x0400;
const uint8_t kValue1 = '1';
TestMemoryStream test_memory_stream(kBaseAddress1, kSize1, kValue1);
@@ -325,7 +325,7 @@ TEST(MinidumpMemoryWriter, ExtraMemory) {
minidump_file_writer.AddStream(&test_memory_stream);
- const uint64_t kBaseAddress2 = 0x0000000000002000ull;
+ const uint64_t kBaseAddress2 = 0x2000;
const uint64_t kSize2 = 0x0400;
const uint8_t kValue2 = 'm';
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698