Make 64-bit Chrome stable report as CHANNEL_STABLE

Make 64-bit Chrome stable report as CHANNEL_STABLE

BUG=407204
TEST=installer_util_unittests
TEST=install x64 stable.  Check chrome://chrome shows 'm' and not 'unknown-m'.

Committed: https://crrev.com/7ebc2c47bb7683224f8978f21f83fba4e1851ab0
Cr-Commit-Position: refs/heads/master@{#291791}

[gab, 2014-08-25 20:44:40]

https://codereview.chromium.org/467303004/diff/1/chrome/installer/util/channe...
File chrome/installer/util/channel_info.cc (right):

https://codereview.chromium.org/467303004/diff/1/chrome/installer/util/channe...
chrome/installer/util/channel_info.cc:31: installer::kChromeChannelStable64
How about we instead just add kChromeChannelStable here? Then anything with
"stable" will come out as Stable, no need for special logic below.

And we can still also default to Stable when faced with "".

[grt (UTC plus 2), 2014-08-25 21:01:29]

A nit from vacationland. Apologies if my comment doesn't make sense. Reviews
from puny devices over bad internets are difficult. Cheers.

https://codereview.chromium.org/467303004/diff/1/chrome/installer/util/channe...
File chrome/installer/util/channel_info.cc (right):

https://codereview.chromium.org/467303004/diff/1/chrome/installer/util/channe...
chrome/installer/util/channel_info.cc:175: else
Since other stable codepaths clear channel_name, this should too. Using
kChromeChannelStable sticks out.

[gab, 2014-08-25 21:16:00]

Thanks Greg

https://codereview.chromium.org/467303004/diff/1/chrome/installer/util/channe...
File chrome/installer/util/channel_info.cc (right):

https://codereview.chromium.org/467303004/diff/1/chrome/installer/util/channe...
chrome/installer/util/channel_info.cc:175: else
On 2014/08/25 21:01:29, grt (no reviews Aug 9 - 27) wrote:
> Since other stable codepaths clear channel_name, this should too. Using
> kChromeChannelStable sticks out.

Yes, exactly what me and Will are currently discussing over IM.

Stable being the empty string just makes everything weird...uh..

[Will Harris, 2014-08-25 21:26:05]

PTAL, added some tests too.

[gab, 2014-08-25 21:42:41]

lgtm, thanks!

[Will Harris, 2014-08-25 21:43:03]

The CQ bit was checked by wfh@chromium.org

[commit-bot: I haz the power, 2014-08-25 21:44:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wfh@chromium.org/467303004/20001

[commit-bot: I haz the power, 2014-08-25 23:48:17]

Committed patchset #2 (20001) as b41a3d02020542c1524b8482785b081a39ebeca4

[commit-bot: I haz the power, 2014-09-10 02:38:41]

Patchset 2 (id:??) landed as
https://crrev.com/7ebc2c47bb7683224f8978f21f83fba4e1851ab0
Cr-Commit-Position: refs/heads/master@{#291791}