Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 467233002: DevTools: Make sure ElementsTreeOutline is correctly rendered when element's hasChildren state chan… (Closed)

Created:
6 years, 4 months ago by vsevik
Modified:
6 years, 4 months ago
Reviewers:
apavlov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Make sure ElementsTreeOutline is correctly rendered when element's hasChildren state changes. R=pfeldman,apavlov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180190

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -50 lines) Patch
M LayoutTests/http/tests/inspector/elements-test.js View 3 chunks +38 lines, -6 lines 0 comments Download
M LayoutTests/inspector/elements/edit-dom-actions-expected.txt View 2 chunks +2 lines, -5 lines 0 comments Download
M LayoutTests/inspector/elements/inline-style-title-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/insert-node-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/inspector/elements/remove-node-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/inspector/elements/shadow-dom-modify-chardata-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/pseudo-elements.html View 2 chunks +12 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/pseudo-elements-expected.txt View 2 chunks +9 lines, -3 lines 0 comments Download
M LayoutTests/inspector/elements/undo-dom-edits.html View 1 chunk +7 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/undo-dom-edits-2.html View 1 chunk +7 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/undo-dom-edits-2-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/inspector/elements/undo-dom-edits-expected.txt View 3 chunks +20 lines, -7 lines 0 comments Download
M LayoutTests/inspector/elements/update-shadowdom-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/user-properties-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsTreeOutline.js View 1 10 chunks +25 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vsevik
PTAL
6 years, 4 months ago (2014-08-13 14:06:16 UTC) #1
apavlov
lgtm https://codereview.chromium.org/467233002/diff/1/Source/devtools/front_end/elements/ElementsTreeOutline.js File Source/devtools/front_end/elements/ElementsTreeOutline.js (right): https://codereview.chromium.org/467233002/diff/1/Source/devtools/front_end/elements/ElementsTreeOutline.js#newcode1329 Source/devtools/front_end/elements/ElementsTreeOutline.js:1329: if (this._node.nodeType() == Node.ELEMENT_NODE && this.hasChildren) ===
6 years, 4 months ago (2014-08-13 14:39:20 UTC) #2
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 4 months ago (2014-08-13 14:55:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/467233002/20001
6 years, 4 months ago (2014-08-13 14:56:49 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 16:22:13 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 180190

Powered by Google App Engine
This is Rietveld 408576698