Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 467193003: ui: Remove unneeded includes of grit/ui_resources.h (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Project:
chromium
Visibility:
Public.

Description

ui: Remove unneeded includes of grit/ui_resources.h Found at first by for f in $(ack --cpp -l 'grit/' ui/); do if ! grep -q ID $f; then echo $f; fi; done Then extended to all folders by using git grep -l grit/ui_resources.h -- '*.cc' instead of the ack call. Somewhat surprisingly, the latter command didn't find more than the first. Also do the same for l10n_util.h and resource_bundle.h using the techniques described in https://codereview.chromium.org/454583002/ BUG=401588 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289470

Patch Set 1 #

Patch Set 2 : bleh #

Patch Set 3 : l10nutil #

Patch Set 4 : bundle #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -35 lines) Patch
M ui/app_list/test/app_list_test_model.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M ui/app_list/views/app_list_background.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/views/app_list_menu_views.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M ui/app_list/views/cached_label.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/views/contents_view.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/views/search_box_view.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/cursor/cursor_loader_x11.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/l10n/time_format_unittest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager_resource_util.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_center_button_bar.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/message_center/views/message_center_view.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/message_center/views/message_view.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/message_center/views/notification_view.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M ui/message_center/views/padded_button.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/shell_dialogs/select_file_dialog.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/bubble/tray_bubble_view.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/button/label_button.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/controls/label.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_config_mac.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_item_view.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_model_adapter.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_model_adapter_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/resize_area.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/corewm/tooltip_aura.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/corewm/tooltip_aura_unittest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/corewm/tooltip_controller_unittest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/examples/text_example.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/window/frame_background.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
6 years, 4 months ago (2014-08-13 16:56:59 UTC) #1
Lei Zhang
lgtm
6 years, 4 months ago (2014-08-13 17:14:14 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-13 17:19:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/467193003/80001
6 years, 4 months ago (2014-08-13 17:21:20 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-13 23:25:19 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 05:41:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 (80001) as 289470

Powered by Google App Engine
This is Rietveld 408576698