Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 467193002: Cleanup namespace usage in Source/core/platform/[A-Z]*.h (Closed)

Created:
6 years, 4 months ago by Sunil Ratnu
Modified:
6 years, 4 months ago
Reviewers:
tkent, abarth-chromium
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Cleanup namespace usage in Source/core/platform/[A-Z]*.h Cleanup namespace usage in Source/core/platform/[A-Z]*.h - Merge multiple |namespace blink {}| block - Remove unnecessary blink:: prefixes - Make blank lines consistent BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -45 lines) Patch
M Source/platform/AsyncFileSystemCallbacks.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/ContentDecryptionModuleResult.h View 2 chunks +5 lines, -7 lines 0 comments Download
M Source/platform/Cookie.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/Crypto.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/CryptoResult.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/platform/EventTracer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/HostWindow.h View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/platform/NotImplemented.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/PODInterval.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/PODRedBlackTree.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/PlatformScreen.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/PurgeableVector.h View 2 chunks +1 line, -5 lines 0 comments Download
M Source/platform/StorageQuotaCallbacks.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/Supplementable.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/Task.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/TestingPlatformSupport.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/TraceLocation.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Sunil Ratnu
Please review this. Thanks!
6 years, 4 months ago (2014-08-13 12:15:12 UTC) #1
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 4 months ago (2014-08-13 16:29:34 UTC) #2
abarth-chromium
lgtm
6 years, 4 months ago (2014-08-13 16:29:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/467193002/1
6 years, 4 months ago (2014-08-13 16:30:01 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-13 19:28:54 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 20:42:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/39569)
6 years, 4 months ago (2014-08-13 20:42:44 UTC) #7
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-14 00:35:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/467193002/1
6 years, 4 months ago (2014-08-14 00:36:22 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 00:37:30 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (1) as 180218

Powered by Google App Engine
This is Rietveld 408576698