Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 467183005: Remove implicit conversions from scoped_refptr to T* in sandbox/ (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
CC:
chromium-reviews, jln+watch_chromium.org, mdempsky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in sandbox/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/28c59a24a00a294250b46c534114cb338f885db7 Cr-Commit-Position: refs/heads/master@{#292052}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sandbox/linux/bpf_dsl/bpf_dsl.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/bpf_dsl/cons_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + jschuh@chromium.org
6 years, 3 months ago (2014-08-26 22:52:03 UTC) #1
dcheng
Unfortunately, we can't make scoped_refptr testable until the conversion operator has been removed. While it ...
6 years, 3 months ago (2014-08-26 22:52:03 UTC) #2
jln (very slow on Chromium)
jln@chromium.org changed reviewers: + jln@chromium.org
6 years, 3 months ago (2014-08-26 23:31:49 UTC) #3
jln (very slow on Chromium)
lgtm
6 years, 3 months ago (2014-08-26 23:31:49 UTC) #4
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-26 23:35:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/467183005/1
6 years, 3 months ago (2014-08-26 23:37:04 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-27 00:01:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (1) as ba2ceba8e8afe308fe61406b28eedd302c0e1308
6 years, 3 months ago (2014-08-27 00:29:27 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:48:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28c59a24a00a294250b46c534114cb338f885db7
Cr-Commit-Position: refs/heads/master@{#292052}

Powered by Google App Engine
This is Rietveld 408576698