Allowing metadata to be read from blob urls

Allowing metadata to be read from blob urls

Blob data is stored in the browser cache. This patch adds
cache path to MediaResourceGetter so that it can read the
metadata from the blob.

BUG=227476
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289868

[amogh.bihani, 2014-08-13 12:58:16]

PTAL.

I tested on the URL mentioned in the bug.http://jsbin.com/oxarap/2
The audio doesn't work in chrome36 but it works in beta37 and ChromeShell.
However, it does not show the total duration because it is unable to read the
metadata. This should fix that.

There is another issue, the media slider to the left of the slider thumb does
not become white. That is because the onBufferingUpdate is not reaching the
player. I am planning to fix that in another CL.

[xhwang, 2014-08-13 15:54:53]

I am not familiar with this code. Add qinmin as the reviewer.

qinmin: PTAL

[qinmin, 2014-08-13 17:33:59]

lgtm % comment

https://codereview.chromium.org/467173002/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/MediaResourceGetter.java
(right):

https://codereview.chromium.org/467173002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/MediaResourceGetter.java:350:
result.add("/data/data/" + PACKAGE_NAME + "/cache/");
add a check here that PACKAGE_NAME cannot be null

[amogh.bihani, 2014-08-14 09:19:48]

+r: Avi@

OWNER's review please. :)

[Avi (use Gerrit), 2014-08-14 14:47:35]

lgtm

stampity stamp

[amogh.bihani, 2014-08-15 02:50:06]

On 2014/08/14 14:47:35, Avi wrote:
> lgtm
> 
> stampity stamp

Thanks for the reviews :)

[amogh.bihani, 2014-08-15 02:50:10]

The CQ bit was checked by amogh.bihani@samsung.com

[commit-bot: I haz the power, 2014-08-15 02:51:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/amogh.bihani@samsung.com/467173002/20001

[commit-bot: I haz the power, 2014-08-15 04:23:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-15 15:29:01]

Committed patchset #2 (20001) as 289868

[Andrew Hayden (chromium.org), 2014-09-11 09:15:21]

On 2014/08/15 15:29:01, I haz the power (commit-bot) wrote:
> Committed patchset #2 (20001) as 289868

For posterity, I do not believe this should have gone through as-is. The static
PACKAGE_NAME variable being modified by each request means that independent
requests may potentially interfere with each other, which is at *best* a benign
error that works by accident (because context.PackageName is almost certainly
going to return the same string every time). In the future, please do not do
this; either pass the Context object where it needs to go, or add some kind of
init() function which clearly and unambiguously gets called exactly one time and
sets whatever "permanent" state variables are required.

https://codereview.chromium.org/561743003/ fixes this as a side effect of
removing the hard-coding of /data/data.