Source/core/frame/DOMTimer.cpp - Issue 467153003: Changing setTimeout to not clamp delays to 1ms minimum, since a 1ms clamp is not in the spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/DOMTimer.cpp

Issue 467153003: Changing setTimeout to not clamp delays to 1ms minimum, since a 1ms clamp is not in the spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Revert test changes Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/DOMTimer.cpp

diff --git a/Source/core/frame/DOMTimer.cpp b/Source/core/frame/DOMTimer.cpp

index 0d3af80cda998f6c3577f0684172e31768b8487d..6e77e87e1455ecab143ecc0ab84bd3fdd4e47e2f 100644

--- a/Source/core/frame/DOMTimer.cpp

+++ b/Source/core/frame/DOMTimer.cpp

@@ -99,7 +99,7 @@ DOMTimer::DOMTimer(ExecutionContext* context, PassOwnPtr<ScheduledAction> action

if (shouldForwardUserGesture(interval, m_nestingLevel))

m_userGestureToken = UserGestureIndicator::currentToken();

- double intervalMilliseconds = std::max(oneMillisecond, interval * oneMillisecond);

+ double intervalMilliseconds = std::max(0.0, interval * oneMillisecond);

if (intervalMilliseconds < minimumInterval && m_nestingLevel >= maxTimerNestingLevel)

intervalMilliseconds = minimumInterval;

if (singleShot)

« no previous file with comments | « no previous file | no next file » | no next file with comments »