Issue 467143002: DevTools: NetworkPanel: support kinetic scroll.

Issue 467143002: DevTools: NetworkPanel: support kinetic scroll. (Closed)

Created:
6 years, 4 months ago by eustas

Modified:
6 years, 4 months ago

Reviewers:
apavlov, vsevik, lushnikov

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: NetworkPanel: support kinetic scroll. BUG=316092 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180186

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -1 line)			Patch
	M	Source/devtools/front_end/ui/ViewportDataGrid.js	View	1 2 3	4 chunks	+42 lines, -1 line	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

apavlov

https://codereview.chromium.org/467143002/diff/20001/Source/devtools/front_end/ui/ViewportDataGrid.js File Source/devtools/front_end/ui/ViewportDataGrid.js (right): https://codereview.chromium.org/467143002/diff/20001/Source/devtools/front_end/ui/ViewportDataGrid.js#newcode28 Source/devtools/front_end/ui/ViewportDataGrid.js:28: this._wheelTraget = null; typo: Traget -> Target https://codereview.chromium.org/467143002/diff/20001/Source/devtools/front_end/ui/ViewportDataGrid.js#newcode253 Source/devtools/front_end/ui/ViewportDataGrid.js:253: ...

6 years, 4 months ago (2014-08-13 13:08:52 UTC) #2

eustas

Thanks. https://codereview.chromium.org/467143002/diff/20001/Source/devtools/front_end/ui/ViewportDataGrid.js File Source/devtools/front_end/ui/ViewportDataGrid.js (right): https://codereview.chromium.org/467143002/diff/20001/Source/devtools/front_end/ui/ViewportDataGrid.js#newcode28 Source/devtools/front_end/ui/ViewportDataGrid.js:28: this._wheelTraget = null; On 2014/08/13 13:08:52, apavlov wrote: ...

6 years, 4 months ago (2014-08-13 13:31:59 UTC) #3

lushnikov

Please, revise issue description https://codereview.chromium.org/467143002/diff/40001/Source/devtools/front_end/ui/ViewportDataGrid.js File Source/devtools/front_end/ui/ViewportDataGrid.js (right): https://codereview.chromium.org/467143002/diff/40001/Source/devtools/front_end/ui/ViewportDataGrid.js#newcode139 Source/devtools/front_end/ui/ViewportDataGrid.js:139: if (previousElement.nextSibling === this._hiddenWheelTarget) Do ...

6 years, 4 months ago (2014-08-13 14:02:06 UTC) #4

eustas

https://codereview.chromium.org/467143002/diff/40001/Source/devtools/front_end/ui/ViewportDataGrid.js File Source/devtools/front_end/ui/ViewportDataGrid.js (right): https://codereview.chromium.org/467143002/diff/40001/Source/devtools/front_end/ui/ViewportDataGrid.js#newcode139 Source/devtools/front_end/ui/ViewportDataGrid.js:139: if (previousElement.nextSibling === this._hiddenWheelTarget) On 2014/08/13 14:02:06, lushnikov wrote: ...

6 years, 4 months ago (2014-08-13 14:25:30 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/467143002/60001

6 years, 4 months ago (2014-08-13 14:51:39 UTC) #9

commit-bot: I haz the power

6 years, 4 months ago (2014-08-13 16:05:03 UTC) #10

Message was sent while issue was closed.

Committed patchset #4 (60001) as 180186

Expand Messages | Collapse Messages