Implements NoReportedDelayOnMac Finch experiment

Implements NoReportedDelayOnMac Finch experiment

This Finch experiment turns reported delays, passed to webrtc::AudioProcessing, off on Mac.
This has to be done at create time to avoid ruining other settings.

BUG=385073
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291056

[bjornv, 2014-08-19 07:36:52]

Dear reviewers. PTAL at this small CL.

I've implemented the Finch experiment without any ifdefs, even though it should
only be feasible to make the change on Mac. This since the experiment config
will make it "Enabled" only on Mac. Any comments on that?

[no longer working on chromium, 2014-08-19 12:42:19]

https://codereview.chromium.org/467133006/diff/1/content/renderer/media/media...
File content/renderer/media/media_stream_audio_processor.cc (right):

https://codereview.chromium.org/467133006/diff/1/content/renderer/media/media...
content/renderer/media/media_stream_audio_processor.cc:418:
config.Set<webrtc::ReportedDelay>(new webrtc::ReportedDelay(false));
if this should never kick in on other platforms, put the code under OS_MACOSX

[no longer working on chromium, 2014-08-19 12:42:34]

On 2014/08/19 12:42:19, xians1 wrote:
>
https://codereview.chromium.org/467133006/diff/1/content/renderer/media/media...
> File content/renderer/media/media_stream_audio_processor.cc (right):
> 
>
https://codereview.chromium.org/467133006/diff/1/content/renderer/media/media...
> content/renderer/media/media_stream_audio_processor.cc:418:
> config.Set<webrtc::ReportedDelay>(new webrtc::ReportedDelay(false));
> if this should never kick in on other platforms, put the code under OS_MACOSX

lgtm if you address my comment.

[Alexei Svitkine (slow), 2014-08-19 14:58:46]

lgtm

[ajm, 2014-08-19 15:37:07]

lgtm

[bjornv, 2014-08-21 04:51:07]

The CQ bit was checked by bjornv@chromium.org

[commit-bot: I haz the power, 2014-08-21 04:51:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bjornv@chromium.org/467133006/20001

[bjornv, 2014-08-21 06:56:05]

The CQ bit was unchecked by bjornv@chromium.org

[bjornv, 2014-08-21 07:01:41]

The CQ bit was checked by bjornv@chromium.org

[commit-bot: I haz the power, 2014-08-21 07:03:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bjornv@chromium.org/467133006/40001

[commit-bot: I haz the power, 2014-08-21 13:35:47]

Committed patchset #3 (40001) as 291056

[andresp-chromium, 2015-01-22 13:58:30]

On 2014/08/21 13:35:47, I haz the power (commit-bot) wrote:
> Committed patchset #3 (40001) as 291056

The ifdefs on this Cl where not really needed. Please avoid it next time.
It is amazing on how this practice is spreading in webrtc finch experiments with
no good reason.