Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 467123002: Revert of Rename WebAnimation to WebCompositorAnimation (patchset #5 of https://codereview.chromium… (Closed)

Created:
6 years, 4 months ago by alancutter (OOO until 2018)
Modified:
6 years, 4 months ago
CC:
blink-reviews, jamesr, shans, rjwright, Mike Lawther (Google), dglazkov+blink, blink-reviews-animation_chromium.org, krit, jbroman, abarth-chromium, blink-layers+watch_chromium.org, dstockwell, Timothy Loh, Rik, rwlbuis, danakj, darktears, Stephen Chennney, Steve Block, pdr., Eric Willigers
Project:
blink
Visibility:
Public.

Description

Revert of Rename WebAnimation to WebCompositorAnimation (patchset #5 of https://codereview.chromium.org/412123002/) Reason for revert: BUG=402897 TBR=samli@chromium.org, jochen@chromium.org, vollick@chromium.org Original issue's description: > Rename WebAnimation to WebCompositorAnimation > > Change WebAnimation to WebCompositorAnimation > Change WebAnimationCurve to WebCompositorAnimationCurve > Change WebAnimationDelegate to WebCompositorAnimationDelegate > > This is patch 3 of 3. It builds on http://crrev.com/413983002 > > BUG=396358 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179910 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180155

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -300 lines) Patch
M Source/core/animation/AnimationTranslationUtilTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/CompositorAnimations.cpp View 9 chunks +30 lines, -30 lines 0 comments Download
M Source/core/animation/CompositorAnimationsImpl.h View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/animation/CompositorAnimationsTest.cpp View 19 chunks +57 lines, -57 lines 0 comments Download
M Source/core/animation/CompositorAnimationsTestHelper.h View 4 chunks +22 lines, -22 lines 0 comments Download
M Source/platform/graphics/GraphicsLayer.h View 12 chunks +29 lines, -29 lines 0 comments Download
M Source/platform/graphics/GraphicsLayer.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/graphics/GraphicsLayerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/scroll/ProgrammaticScrollAnimator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/LinkHighlight.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/web/LinkHighlight.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
A + public/platform/WebAnimation.h View 1 chunk +42 lines, -16 lines 0 comments Download
A + public/platform/WebAnimationCurve.h View 1 chunk +23 lines, -16 lines 0 comments Download
A + public/platform/WebAnimationDelegate.h View 1 chunk +10 lines, -10 lines 0 comments Download
M public/platform/WebCompositorAnimation.h View 1 chunk +1 line, -37 lines 0 comments Download
M public/platform/WebCompositorAnimationCurve.h View 1 chunk +1 line, -27 lines 0 comments Download
M public/platform/WebCompositorAnimationDelegate.h View 1 chunk +2 lines, -16 lines 0 comments Download
M public/platform/WebCompositorSupport.h View 3 chunks +4 lines, -4 lines 0 comments Download
M public/platform/WebFilterAnimationCurve.h View 2 chunks +2 lines, -2 lines 0 comments Download
M public/platform/WebFloatAnimationCurve.h View 2 chunks +2 lines, -2 lines 0 comments Download
M public/platform/WebLayer.h View 3 chunks +5 lines, -5 lines 0 comments Download
M public/platform/WebScrollOffsetAnimationCurve.h View 1 chunk +2 lines, -2 lines 0 comments Download
M public/platform/WebTransformAnimationCurve.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
alancutter (OOO until 2018)
The CQ bit was checked by alancutter@chromium.org
6 years, 4 months ago (2014-08-13 07:00:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/467123002/1
6 years, 4 months ago (2014-08-13 07:01:09 UTC) #2
samli
lgtm
6 years, 4 months ago (2014-08-13 07:02:57 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-13 08:01:12 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 08:13:47 UTC) #5
Message was sent while issue was closed.
Change committed as 180155

Powered by Google App Engine
This is Rietveld 408576698