Adds a skeleton component app for Always-On Hotwording opt-in flow.

Adds a skeleton component app for Always-On Hotwording opt-in flow.

BUG=390086
Committed: https://crrev.com/599e35124ed14e04c87cc26d5629b36223f96ca9
Cr-Commit-Position: refs/heads/master@{#292338}

[rpetterson, 2014-08-19 18:55:29]

https://codereview.chromium.org/467113004/diff/1/chrome/browser/extensions/co...
File chrome/browser/extensions/component_loader.cc (right):

https://codereview.chromium.org/467113004/diff/1/chrome/browser/extensions/co...
chrome/browser/extensions/component_loader.cc:516: if
(command_line->HasSwitch(switches::kEnableExperimentalHotwording)) {
I'd make this like the other component extensions where you create a function
like AddHotwordVerificationApp() and do the check in that function. It's cleaner
and I foresee other checks such as field trials that we will need to include.

https://codereview.chromium.org/467113004/diff/1/chrome/browser/resources/hot...
File chrome/browser/resources/hotword_audio_verification/background.js (right):

https://codereview.chromium.org/467113004/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/background.js:11: 'height':
535
I assume these sizes are from the mocks? Is there any concern about different
sized screens?

https://codereview.chromium.org/467113004/diff/1/chrome/browser/resources/hot...
File chrome/browser/resources/hotword_audio_verification/manifest.json (right):

https://codereview.chromium.org/467113004/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/manifest.json:10: "scripts":
["background.js"]
Is this going to be a persistent app? An event page is more appropriate in most
cases: https://developer.chrome.com/extensions/event_pages

https://codereview.chromium.org/467113004/diff/1/chrome/common/extensions/ext...
File chrome/common/extensions/extension_constants.h (right):

https://codereview.chromium.org/467113004/diff/1/chrome/common/extensions/ext...
chrome/common/extensions/extension_constants.h:120: extern const char
kHotwordAudioVerificationExtensionId[];
Should this be an App rather an an Extension?

[kcarattini, 2014-08-20 03:13:27]

https://codereview.chromium.org/467113004/diff/1/chrome/browser/extensions/co...
File chrome/browser/extensions/component_loader.cc (right):

https://codereview.chromium.org/467113004/diff/1/chrome/browser/extensions/co...
chrome/browser/extensions/component_loader.cc:516: if
(command_line->HasSwitch(switches::kEnableExperimentalHotwording)) {
On 2014/08/19 18:55:29, rpetterson wrote:
> I'd make this like the other component extensions where you create a function
> like AddHotwordVerificationApp() and do the check in that function. It's
cleaner
> and I foresee other checks such as field trials that we will need to include.

Done. Also moved the call to AddDefaultComponentExtensions() since there is no
longer a background page.

https://codereview.chromium.org/467113004/diff/1/chrome/browser/resources/hot...
File chrome/browser/resources/hotword_audio_verification/background.js (right):

https://codereview.chromium.org/467113004/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/background.js:11: 'height':
535
On 2014/08/19 18:55:29, rpetterson wrote:
> I assume these sizes are from the mocks? Is there any concern about different
> sized screens?

Yes, the size is about the size of the mock. Hwi will be sending me final assets
and exact sizes in the coming weeks, so I expect this to change.

I don't think there's concern about screen size at the moment, since this is
smaller than the screen of any ChromeOS device that I know of.

https://codereview.chromium.org/467113004/diff/1/chrome/browser/resources/hot...
File chrome/browser/resources/hotword_audio_verification/manifest.json (right):

https://codereview.chromium.org/467113004/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword_audio_verification/manifest.json:10: "scripts":
["background.js"]
On 2014/08/19 18:55:29, rpetterson wrote:
> Is this going to be a persistent app? An event page is more appropriate in
most
> cases: https://developer.chrome.com/extensions/event_pages

Done.

https://codereview.chromium.org/467113004/diff/1/chrome/common/extensions/ext...
File chrome/common/extensions/extension_constants.h (right):

https://codereview.chromium.org/467113004/diff/1/chrome/common/extensions/ext...
chrome/common/extensions/extension_constants.h:120: extern const char
kHotwordAudioVerificationExtensionId[];
On 2014/08/19 18:55:29, rpetterson wrote:
> Should this be an App rather an an Extension?

Done.

[rpetterson, 2014-08-20 23:44:14]

LGTM from a hotword/functionality standpoint

[kcarattini, 2014-08-21 00:27:06]

Thanks, Rachel!

James, could you please review for OWNERS approval?

Thanks,
Kendra

[kcarattini, 2014-08-22 01:06:47]

Hi Scott,

Could you please review for OWNERS approval?

Thanks,
Kendra

[sky, 2014-08-22 15:55:16]

What files do you need me to review?

[rpetterson, 2014-08-22 19:43:05]

On 2014/08/22 15:55:16, sky wrote:
> What files do you need me to review?

sky, she could use someone for browser_resources.grd

For browser/resources, adding idbeam@
For browser/extensions and common/extensions, adding benwells@

[Dan Beam, 2014-08-22 21:52:16]

https://codereview.chromium.org/467113004/diff/40001/chrome/browser/resources...
File chrome/browser/resources/hotword_audio_verification/eventPage.js (right):

https://codereview.chromium.org/467113004/diff/40001/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/eventPage.js:1: // Copyright
2014 The Chromium Authors. All rights reserved.
this file should be named event_page.js

https://codereview.chromium.org/467113004/diff/40001/chrome/browser/resources...
File chrome/browser/resources/hotword_audio_verification/manifest.json (right):

https://codereview.chromium.org/467113004/diff/40001/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/manifest.json:2: //
chrome-extension://abjokfonkihficiokmkfboogholifghn/
^ JSON doesn't allow comments...

https://codereview.chromium.org/467113004/diff/40001/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/manifest.json:7: 
remove \n

https://codereview.chromium.org/467113004/diff/40001/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/manifest.json:8: "app": {
indent off

[rpetterson, 2014-08-22 21:55:14]

https://codereview.chromium.org/467113004/diff/40001/chrome/browser/resources...
File chrome/browser/resources/hotword_audio_verification/manifest.json (right):

https://codereview.chromium.org/467113004/diff/40001/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/manifest.json:2: //
chrome-extension://abjokfonkihficiokmkfboogholifghn/
On 2014/08/22 21:52:15, Dan Beam wrote:
> ^ JSON doesn't allow comments...

In general no, but it does for component extensions. See hotword_helper, for
example.

[sky, 2014-08-22 22:35:30]

LGTM

[kcarattini, 2014-08-25 00:43:22]

https://codereview.chromium.org/467113004/diff/40001/chrome/browser/resources...
File chrome/browser/resources/hotword_audio_verification/eventPage.js (right):

https://codereview.chromium.org/467113004/diff/40001/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/eventPage.js:1: // Copyright
2014 The Chromium Authors. All rights reserved.
On 2014/08/22 21:52:15, Dan Beam wrote:
> this file should be named event_page.js

Done.

https://codereview.chromium.org/467113004/diff/40001/chrome/browser/resources...
File chrome/browser/resources/hotword_audio_verification/manifest.json (right):

https://codereview.chromium.org/467113004/diff/40001/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/manifest.json:7: 
On 2014/08/22 21:52:15, Dan Beam wrote:
> remove \n

Done.

https://codereview.chromium.org/467113004/diff/40001/chrome/browser/resources...
chrome/browser/resources/hotword_audio_verification/manifest.json:8: "app": {
On 2014/08/22 21:52:15, Dan Beam wrote:
> indent off

Done.

[benwells, 2014-08-25 03:21:58]

https://codereview.chromium.org/467113004/diff/80001/chrome/browser/extension...
File chrome/browser/extensions/component_loader.cc (right):

https://codereview.chromium.org/467113004/diff/80001/chrome/browser/extension...
chrome/browser/extensions/component_loader.cc:469:
AddHotwordAudioVerificationApp();
I think tihs should be moved down to
AddDefaultComponentExtensionsWithBackgroundPages, as apps have background pages.

[kcarattini, 2014-08-25 04:04:26]

https://codereview.chromium.org/467113004/diff/80001/chrome/browser/extension...
File chrome/browser/extensions/component_loader.cc (right):

https://codereview.chromium.org/467113004/diff/80001/chrome/browser/extension...
chrome/browser/extensions/component_loader.cc:469:
AddHotwordAudioVerificationApp();
On 2014/08/25 03:21:58, benwells wrote:
> I think tihs should be moved down to
> AddDefaultComponentExtensionsWithBackgroundPages, as apps have background
pages.

Done.

[benwells, 2014-08-25 04:06:24]

yay! lgtm

[Dan Beam, 2014-08-25 16:47:55]

c/b/resources lgtm

[kcarattini, 2014-08-26 00:30:59]

The CQ bit was checked by kcarattini@chromium.org

[commit-bot: I haz the power, 2014-08-26 00:34:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kcarattini@chromium.org/467113004/100001

[commit-bot: I haz the power, 2014-08-26 01:22:58]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/46114)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/51331)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-26 01:24:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-26 01:24:49]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/46143)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kcarattini, 2014-08-27 07:51:22]

The CQ bit was checked by kcarattini@chromium.org

[commit-bot: I haz the power, 2014-08-27 07:51:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kcarattini@chromium.org/467113004/100001

[commit-bot: I haz the power, 2014-08-27 08:03:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/46842)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/52203)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-27 08:04:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 08:04:28]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kcarattini, 2014-08-28 01:44:48]

The CQ bit was checked by kcarattini@chromium.org

[commit-bot: I haz the power, 2014-08-28 01:46:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kcarattini@chromium.org/467113004/120001

[commit-bot: I haz the power, 2014-08-28 02:52:32]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-28 03:14:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 03:14:16]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kcarattini, 2014-08-28 05:31:27]

The CQ bit was checked by kcarattini@chromium.org

[commit-bot: I haz the power, 2014-08-28 05:32:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kcarattini@chromium.org/467113004/120001

[commit-bot: I haz the power, 2014-08-28 06:33:43]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-28 07:05:17]

Committed patchset #7 (id:120001) as 993949b7c8c5fbf5980615c13664bf839e8380e8

[commit-bot: I haz the power, 2014-09-10 02:58:08]

Patchset 7 (id:??) landed as
https://crrev.com/599e35124ed14e04c87cc26d5629b36223f96ca9
Cr-Commit-Position: refs/heads/master@{#292338}