runtime/vm/assembler_arm.cc - Issue 467103005: Fixes to support ARMv5 lego mindstorm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_arm.cc

Issue 467103005: Fixes to support ARMv5 lego mindstorm. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/assembler_arm.cc

===================================================================

--- runtime/vm/assembler_arm.cc (revision 39210)

+++ runtime/vm/assembler_arm.cc (working copy)

@@ -558,6 +558,9 @@

Condition cond) {

ASSERT(regs != 0);

EmitMultiMemOp(cond, am, false, base, regs);

+ if (TargetCPUFeatures::arm_version() == ARMv5TE) {

regis 2014/08/13 19:47:39 Can you add a comment explaining why this is neede

zra 2014/08/13 20:08:55 Done.

+ nop();

+ }

}

@@ -2810,6 +2813,7 @@

if (TargetCPUFeatures::integer_division_supported()) {

sdiv(result, left, right);

} else {

+ ASSERT(TargetCPUFeatures::vfp_supported());

SRegister stmpl = static_cast<SRegister>(2 * tmpl);

SRegister stmpr = static_cast<SRegister>(2 * tmpr);

vmovsr(stmpl, left);

« no previous file with comments | « runtime/vm/assembler_arm.h ('k') | runtime/vm/assembler_arm64.h » ('j') | no next file with comments »