Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 467103004: Subzero: Convert lit test llvm-mc -arch arguments to full -triple. (Closed)

Created:
6 years, 4 months ago by jvoung (off chromium)
Modified:
6 years, 4 months ago
Reviewers:
Jim Stichnoth, wala
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Convert lit test llvm-mc -arch arguments to full -triple. Mostly to make them a bit more portable across OSes. Otherwise the OS assumed by llvm-mc is the build/host OS. So, on Mac llvm-mc will assume it's targeting darwin and only accepts macho assembler directives. Assembler directives like .rodata.cst8 are not accepted (I'm guessing it uses .cstring, .literal4, etc. instead?). Force an OS (NaCl) so that ELF-related assembler macros make sense. Also remove a now unused function typeIdentString to make clang happy. Example errors: Command 5 Stderr: <stdin>:5:2: error: unknown directive .type fixed_400,@function ^ <stdin>:23:2: error: unknown directive .type variable_n,@function ^ <stdin>:40:11: error: mach-o section specifier uses an unknown section type .section .rodata.cst4,"aM",@progbits,4 ^ <stdin>:42:11: error: mach-o section specifier uses an unknown section type .section .rodata.cst8,"aM",@progbits,8 ^ BUG=none R=stichnot@chromium.org, wala@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=c8e8781

Patch Set 1 #

Patch Set 2 : revert py change #

Patch Set 3 : remove unused func to make clang happy #

Patch Set 4 : x #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -77 lines) Patch
M src/IceTargetLoweringX8632.cpp View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
M tests_lit/llvm2ice_tests/64bit.pnacl.ll View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/address-mode-opt.ll View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/alloc.ll View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/bitcast.ll View 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/callindirect.pnacl.ll View 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/cmp-opt.ll View 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/convert.ll View 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/div_legalization.ll View 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/fp.pnacl.ll View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/fpconst.pnacl.ll View 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/globalinit.pnacl.ll View 1 chunk +1 line, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/mangle.ll View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-atomic-cmpxchg-optimization.ll View 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-atomic-fence-all.ll View 1 chunk +1 line, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/nacl-atomic-intrinsics.ll View 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll View 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/sdiv.ll View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/select-opt.ll View 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/shift.ll View 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/simple-loop.ll View 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/undef.ll View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/unreachable.ll View 1 chunk +1 line, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/vector-arg.ll View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-arith.ll View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-bitcast.ll View 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-cast.ll View 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-fcmp.ll View 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-icmp.ll View 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-ops.ll View 1 chunk +4 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-select.ll View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jvoung (off chromium)
6 years, 4 months ago (2014-08-13 18:00:43 UTC) #1
Jim Stichnoth
lgtm
6 years, 4 months ago (2014-08-13 19:15:12 UTC) #2
wala
lgtm
6 years, 4 months ago (2014-08-13 19:32:54 UTC) #3
jvoung (off chromium)
6 years, 4 months ago (2014-08-13 20:21:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as c8e8781 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698