Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 467073002: Only initialize the input method list for once, no need to re-initialize for each profile. (Closed)

Created:
6 years, 4 months ago by Shu Chen
Modified:
6 years, 4 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, Alexander Alekseev
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Only initialize the input method list for once, no need to re-initialize for each profile. BUG=402222 TEST=Verified on linux_chromeos. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289414

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -29 lines) Patch
M chrome/browser/chromeos/input_method/input_method_manager_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M chromeos/ime/input_method_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Shu Chen
Can you guys please review this cl? nona@ for overall solution. oshima@ for approval of ...
6 years, 4 months ago (2014-08-13 03:09:44 UTC) #1
Seigo Nonaka
lgtm, thank you for cleaning up.
6 years, 4 months ago (2014-08-13 03:56:39 UTC) #2
oshima
lgtm
6 years, 4 months ago (2014-08-13 06:22:38 UTC) #3
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 4 months ago (2014-08-13 06:23:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/467073002/1
6 years, 4 months ago (2014-08-13 06:25:19 UTC) #5
Shu Chen
+kalman@ for owner's approval for component_loader.cc.
6 years, 4 months ago (2014-08-13 08:12:58 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-13 09:08:45 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 09:13:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/3895)
6 years, 4 months ago (2014-08-13 09:13:03 UTC) #9
not at google - send to devlin
lgtm
6 years, 4 months ago (2014-08-13 19:57:34 UTC) #10
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 4 months ago (2014-08-13 23:27:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/467073002/1
6 years, 4 months ago (2014-08-13 23:30:00 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 23:44:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (1) as 289414

Powered by Google App Engine
This is Rietveld 408576698