Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 467043002: Adds locale strings to Chromecast build. (Closed)

Created:
6 years, 4 months ago by gunsch
Modified:
6 years, 4 months ago
Reviewers:
lcwu1, byungchul
CC:
chromium-reviews, ozone-reviews_chromium.org, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : unrebase for review #

Patch Set 3 : remove build/gyp_chromium #

Total comments: 20

Patch Set 4 : review comments #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+522 lines, -60 lines) Patch
M chromecast/DEPS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/chromecast.gyp View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
A chromecast/chromecast_locales.gyp View 1 chunk +69 lines, -0 lines 0 comments Download
A chromecast/common/cast_resource_delegate.h View 1 2 3 1 chunk +73 lines, -0 lines 0 comments Download
A chromecast/common/cast_resource_delegate.cc View 1 2 3 1 chunk +107 lines, -0 lines 0 comments Download
M chromecast/shell/app/cast_main_delegate.h View 2 chunks +5 lines, -1 line 0 comments Download
M chromecast/shell/app/cast_main_delegate.cc View 1 2 3 2 chunks +12 lines, -6 lines 0 comments Download
M chromecast/shell/browser/cast_http_user_agent_settings.cc View 1 2 3 2 chunks +7 lines, -1 line 0 comments Download
M chromecast/shell/browser/resources/resource_ids View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
A chromecast/shell/settings/chromecast_settings.grd View 1 chunk +167 lines, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_am.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_ar.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_bg.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_bn.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_ca.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_cs.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_da.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_de.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_el.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_en-GB.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_es.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_es-419.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_et.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_fa.xtb View 1 chunk +1 line, -1 line 0 comments Download
A + chromecast/shell/settings/chromecast_settings_fi.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_fil.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_fr.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_gu.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_he.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_hi.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_hr.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_hu.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_id.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_it.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_ja.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_kn.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_ko.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_lt.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_lv.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_ml.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_mr.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_ms.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_nb.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_nl.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_pl.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_pt-BR.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_pt-PT.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_ro.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_ru.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_sk.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_sl.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_sr.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_sv.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_sw.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_ta.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_te.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_th.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_tr.xtb View 1 chunk +2 lines, -2 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_uk.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_vi.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_zh-CN.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/shell/settings/chromecast_settings_zh-TW.xtb View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/tools/build/chromecast_repack_locales.py View 1 2 3 6 chunks +21 lines, -49 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
gunsch
6 years, 4 months ago (2014-08-13 00:06:19 UTC) #1
gunsch
On 2014/08/13 00:06:19, gunsch wrote: It looks like Rietveld doesn't handle chained git commits/CL at ...
6 years, 4 months ago (2014-08-13 00:12:02 UTC) #2
lcwu1
https://codereview.chromium.org/467043002/diff/1/build/gyp_chromium File build/gyp_chromium (right): https://codereview.chromium.org/467043002/diff/1/build/gyp_chromium#newcode34 build/gyp_chromium:34: sys.path.insert(1, os.path.join(chrome_src, 'chromecast', 'tools', 'build')) This change is already ...
6 years, 4 months ago (2014-08-14 15:08:16 UTC) #3
gunsch
Yeah, I tried to indicate that patch set 1 combined a few CLs, but guess ...
6 years, 4 months ago (2014-08-14 19:59:50 UTC) #4
byungchul
https://codereview.chromium.org/467043002/diff/40001/chromecast/common/cast_resource_delegate.cc File chromecast/common/cast_resource_delegate.cc (right): https://codereview.chromium.org/467043002/diff/40001/chromecast/common/cast_resource_delegate.cc#newcode18 chromecast/common/cast_resource_delegate.cc:18: return g_instance_; DCHECK(g_instance)? https://codereview.chromium.org/467043002/diff/40001/chromecast/common/cast_resource_delegate.cc#newcode22 chromecast/common/cast_resource_delegate.cc:22: : Delegate() { Not ...
6 years, 4 months ago (2014-08-14 20:34:11 UTC) #5
lcwu1
https://codereview.chromium.org/467043002/diff/40001/chromecast/common/cast_resource_delegate.h File chromecast/common/cast_resource_delegate.h (right): https://codereview.chromium.org/467043002/diff/40001/chromecast/common/cast_resource_delegate.h#newcode67 chromecast/common/cast_resource_delegate.h:67: static CastResourceDelegate* g_instance_; Instead of exposing g_instance_ here as ...
6 years, 4 months ago (2014-08-14 22:38:46 UTC) #6
gunsch
https://codereview.chromium.org/467043002/diff/40001/chromecast/common/cast_resource_delegate.cc File chromecast/common/cast_resource_delegate.cc (right): https://codereview.chromium.org/467043002/diff/40001/chromecast/common/cast_resource_delegate.cc#newcode18 chromecast/common/cast_resource_delegate.cc:18: return g_instance_; On 2014/08/14 20:34:11, byungchul wrote: > DCHECK(g_instance)? ...
6 years, 4 months ago (2014-08-15 00:04:28 UTC) #7
byungchul
lgtm
6 years, 4 months ago (2014-08-15 00:10:48 UTC) #8
lcwu1
lgtm
6 years, 4 months ago (2014-08-15 00:22:35 UTC) #9
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 4 months ago (2014-08-15 17:10:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/467043002/80001
6 years, 4 months ago (2014-08-15 17:17:15 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 20:30:18 UTC) #12
Message was sent while issue was closed. 
Committed patchset #5 (80001) as 290000

Powered by Google App Engine
This is Rietveld 408576698