Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Unified Diff: chrome/renderer/devtools_agent_filter.cc

Issue 467043: Revert 34040 - DevTools: make possible profiling of scripts doing heavy calcu... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/devtools_agent_filter.h ('k') | webkit/glue/devtools/debugger_agent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/devtools_agent_filter.cc
===================================================================
--- chrome/renderer/devtools_agent_filter.cc (revision 34040)
+++ chrome/renderer/devtools_agent_filter.cc (working copy)
@@ -6,7 +6,6 @@
#include "base/message_loop.h"
#include "chrome/common/devtools_messages.h"
-#include "chrome/common/render_messages.h"
#include "chrome/renderer/devtools_agent.h"
#include "chrome/renderer/plugin_channel_host.h"
#include "chrome/renderer/render_view.h"
@@ -25,13 +24,8 @@
current->SetNestableTasksAllowed(old_state);
}
-// static
-IPC::Channel* DevToolsAgentFilter::channel_ = NULL;
-// static
-int DevToolsAgentFilter::current_routing_id_ = 0;
-
DevToolsAgentFilter::DevToolsAgentFilter()
- : message_handled_(false) {
+ : current_routing_id_(0) {
WebDevToolsAgent::setMessageLoopDispatchHandler(
&DevToolsAgentFilter::DispatchMessageLoop);
}
@@ -41,16 +35,15 @@
bool DevToolsAgentFilter::OnMessageReceived(const IPC::Message& message) {
// Dispatch debugger commands directly from IO.
- message_handled_ = true;
+ bool handled = true;
current_routing_id_ = message.routing_id();
IPC_BEGIN_MESSAGE_MAP(DevToolsAgentFilter, message)
IPC_MESSAGE_HANDLER(DevToolsAgentMsg_DebuggerCommand, OnDebuggerCommand)
IPC_MESSAGE_HANDLER(DevToolsAgentMsg_DebuggerPauseScript,
OnDebuggerPauseScript)
- IPC_MESSAGE_HANDLER(DevToolsAgentMsg_RpcMessage, OnRpcMessage)
- IPC_MESSAGE_UNHANDLED(message_handled_ = false)
+ IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
- return message_handled_;
+ return handled;
}
void DevToolsAgentFilter::OnDebuggerCommand(const std::string& command) {
@@ -61,33 +54,3 @@
void DevToolsAgentFilter::OnDebuggerPauseScript() {
WebDevToolsAgent::debuggerPauseScript();
}
-
-void DevToolsAgentFilter::OnRpcMessage(const std::string& class_name,
- const std::string& method_name,
- const std::string& param1,
- const std::string& param2,
- const std::string& param3) {
- message_handled_ = WebDevToolsAgent::dispatchMessageFromFrontendOnIOThread(
- WebString::fromUTF8(class_name),
- WebString::fromUTF8(method_name),
- WebString::fromUTF8(param1),
- WebString::fromUTF8(param2),
- WebString::fromUTF8(param3));
-}
-
-// static
-void DevToolsAgentFilter::SendRpcMessage(const std::string& class_name,
- const std::string& method_name,
- const std::string& param1,
- const std::string& param2,
- const std::string& param3) {
- IPC::Message* m = new ViewHostMsg_ForwardToDevToolsClient(
- current_routing_id_,
- DevToolsClientMsg_RpcMessage(
- class_name,
- method_name,
- param1,
- param2,
- param3));
- channel_->Send(m);
-}
« no previous file with comments | « chrome/renderer/devtools_agent_filter.h ('k') | webkit/glue/devtools/debugger_agent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698