Adjust our sniffing hueristics to better match Firefox....

Adjust our sniffing hueristics to better match Firefox.

We used to be willing to sniff "safe" mime types from
application/octet-stream, but we ran into compatibility
problems with sites that wanted to use
application/octet-stream to trigger a download.  To have
better compatibility with these sites, we've changed our
sniffing algorith to be slightly less agressive.

BUG=29354
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34237

[Aaron Boodman, 2009-12-06 20:05:50]

lgtm

[Evan Martin, 2009-12-06 20:52:58]

s/algorith/algorithm/ in description

[abarth-chromium, 2009-12-06 20:59:57]

My keyboard has a weak "m" key.  :(  Will fix.  Thanks.

[Evan Martin, 2009-12-06 21:19:14]

To add to Darin's concern, note that both Firefox and Safari have special-casing
depending on the extension of the URL.  That is hacky enough (e.g. should
"foo.com/bar.gif?size=large" trigger it?) that I expect they only added it once
they discovered the simpler behavior we have doesn't work.

[abarth-chromium, 2009-12-06 21:31:57]

According to my notes in this file, Firefox only special-cases the
type of download based on the file extension.  We do the same thing
because once you're talking to the OS, the extension is what
determines the type.

You're right, though, that Safari looks at the extension earlier.
However, I suspect this is collateral damage from their handling of
the HTML case.

Adam

[abarth-chromium, 2009-12-06 23:44:35]

On 2009/12/06 20:52:58, Evan Martin wrote:
> s/algorith/algorithm/ in description

Oops.  I forgot to fix this.