Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 467033006: Check for type registeration of Custom element before validating options (Closed)

Created:
6 years, 4 months ago by deepak.sa
Modified:
6 years, 4 months ago
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Check for type registeration of Custom element before validating options Early return form CustomElementRegistry::registerElement, if type is already registered, before validating options. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180837

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M Source/core/dom/custom/CustomElementRegistry.cpp View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
deepak.sa
PTAL? Thanks!
6 years, 4 months ago (2014-08-23 13:24:52 UTC) #1
dominicc (has gone to gerrit)
On 2014/08/23 13:24:52, deepak.sa wrote: > PTAL? > Thanks! LGTM
6 years, 4 months ago (2014-08-25 00:12:39 UTC) #2
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 4 months ago (2014-08-25 00:12:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/467033006/1
6 years, 4 months ago (2014-08-25 00:13:14 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-25 00:43:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 180837

Powered by Google App Engine
This is Rietveld 408576698