net/ftp: Fix control response parsing for a corner cases where the first line...

net/ftp/ftp_ctrl_response_buffer_unittest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/ftp/ftp_ctrl_response_buffer.h"
 
 #include <string.h>
 
 #include "net/base/net_errors.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 78 matching lines @@
 
   net::FtpCtrlResponse response = buffer_.PopResponse();
   EXPECT_FALSE(buffer_.ResponseAvailable());
   EXPECT_EQ(230, response.status_code);
   ASSERT_EQ(3U, response.lines.size());
   EXPECT_EQ("FirstLineContinued", response.lines[0]);
   EXPECT_EQ("SecondLine215 Continued", response.lines[1]);
   EXPECT_EQ("LastLine", response.lines[2]);
 }
 
+TEST_F(FtpCtrlResponseBufferTest, MultilineContinuationZeroLength) {
+  // For the corner case from bug 29322.
+  EXPECT_EQ(net::OK, PushDataToBuffer("230-\r\n"));
+  EXPECT_FALSE(buffer_.ResponseAvailable());
+
+  EXPECT_EQ(net::OK, PushDataToBuffer("example.com\r\n"));
+  EXPECT_FALSE(buffer_.ResponseAvailable());
+
+  EXPECT_EQ(net::OK, PushDataToBuffer("230 LastLine\r\n"));
+  EXPECT_TRUE(buffer_.ResponseAvailable());
+
+  net::FtpCtrlResponse response = buffer_.PopResponse();
+  EXPECT_FALSE(buffer_.ResponseAvailable());
+  EXPECT_EQ(230, response.status_code);
+  ASSERT_EQ(2U, response.lines.size());
+  EXPECT_EQ("example.com", response.lines[0]);
+  EXPECT_EQ("LastLine", response.lines[1]);
+}
+
 TEST_F(FtpCtrlResponseBufferTest, SimilarContinuation) {
   EXPECT_EQ(net::OK, PushDataToBuffer("230-FirstLine\r\n"));
   EXPECT_FALSE(buffer_.ResponseAvailable());
 
   // Notice the space at the start of the line. It should be recognized
   // as a continuation, and not the last line.
   EXPECT_EQ(net::OK, PushDataToBuffer(" 230 Continued\r\n"));
   EXPECT_FALSE(buffer_.ResponseAvailable());
 
   EXPECT_EQ(net::OK, PushDataToBuffer("230 TrueLastLine\r\n"));
@@ skipping 34 matching lines @@
   EXPECT_EQ(net::ERR_INVALID_RESPONSE, PushDataToBuffer("Non-numeric\r\n"));
   EXPECT_FALSE(buffer_.ResponseAvailable());
 }
 
 TEST_F(FtpCtrlResponseBufferTest, OutOfRangeResponse) {
   EXPECT_EQ(net::ERR_INVALID_RESPONSE, PushDataToBuffer("777 OK?\r\n"));
   EXPECT_FALSE(buffer_.ResponseAvailable());
 }
 
 }  // namespace