Issue 467028: POSIX: sanitise signal handling state at startup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 467028: POSIX: sanitise signal handling state at startup. (Closed)

Created:
11 years ago by agl

Modified:
9 years, 7 months ago

Reviewers:
Markus (顧孟勤)

CC:
chromium-reviews_googlegroups.com, Lei Zhang

Visibility:
Public.

Description

POSIX: sanitise signal handling state at startup. BUG=29279 r33897.

Patch Set 1 #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	chrome/app/chrome_dll_main.cc	View		1 chunk	+16 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Markus (顧孟勤)

11 years ago (2009-12-05 00:17:40 UTC) #2

LGTM

http://codereview.chromium.org/467028/diff/1/2
File chrome/app/chrome_dll_main.cc (right):

http://codereview.chromium.org/467028/diff/1/2#newcode353
chrome/app/chrome_dll_main.cc:353: static const int signals_to_reset[] =
Please add the missing signals, that I mentioned to you (SIGBUS, SIGTRAP, ...)

Expand Messages | Collapse Messages