Bookmark sync windows for non-English locales were too short, cutting off the...

Bookmark sync windows for non-English locales were too short, cutting off the bottom button.

BUG=29447
TEST= sync bookmarks in a non-English locale; window should not be too short.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33907

[Finnur, 2009-12-04 22:53:32]

LGTM.

(That was exciting). :)

[Finnur, 2009-12-04 22:55:40]

This needs to be tested on XP. XP vs Vista/W7 dimensions are not the same,
unfortunately. :/

On 2009/12/04 22:53:32, Finnur wrote:
> LGTM.
> 
> (That was exciting). :)

[Finnur, 2009-12-04 22:56:13]

The XP dialogs are narrower than Vista.

(sorry for the multipost) :)

On 2009/12/04 22:55:40, Finnur wrote:
> This needs to be tested on XP. XP vs Vista/W7 dimensions are not the same,
> unfortunately. :/
> 
> On 2009/12/04 22:53:32, Finnur wrote:
> > LGTM.
> > 
> > (That was exciting). :)

[its_nick_at_chromium_org, 2009-12-04 22:58:35]

This dialog is the same size on XP and Vista -- it's sized in terms of the
default web font, not the default UI font.

 - nick

On Fri, Dec 4, 2009 at 2:56 PM, <finnur@chromium.org> wrote:

> The XP dialogs are narrower than Vista.
>
> (sorry for the multipost) :)
>
>
> On 2009/12/04 22:55:40, Finnur wrote:
>
>> This needs to be tested on XP. XP vs Vista/W7 dimensions are not the same,
>> unfortunately. :/
>>
>
>  On 2009/12/04 22:53:32, Finnur wrote:
>> > LGTM.
>> >
>> > (That was exciting). :)
>>
>
>
>
> http://codereview.chromium.org/467025
>

[Miranda Callahan, 2009-12-04 23:20:19]

Thanks, Nick and Finnur --

yes, works just the same in XP.

[Finnur, 2009-12-04 23:57:56]

I see. Well, excellent then. LGTM.

On Fri, Dec 4, 2009 at 15:20, <mirandac@chromium.org> wrote:

> Thanks, Nick and Finnur --
>
> yes, works just the same in XP.
>
>
>
> http://codereview.chromium.org/467025
>