Issue 467022: Remove the sync menu item from Linux....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 467022: Remove the sync menu item from Linux.... (Closed)

Created:
11 years ago by Zachary Kuznia

Modified:
9 years, 7 months ago

Reviewers:
ncarter (slow)

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/branches/249/src/

Visibility:
Public.

Description

Remove the sync menu item from Linux. BUG=29425 TEST=Open the wrench menu. There should not be a sync menu item. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33898

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	chrome/browser/gtk/standard_menus.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ncarter (slow)

11 years ago (2009-12-04 20:50:36 UTC) #2

LGTM

On Fri, Dec 4, 2009 at 11:23 AM, <zork@chromium.org> wrote:

> Reviewers: nick,
>
> Description:
> Remove the sync menu item from Linux.
>
> BUG=29425
> TEST=Open the wrench menu.  There should not be a sync menu item.
>
>
> Please review this at http://codereview.chromium.org/467022
>
> SVN Base: svn://chrome-svn/chrome/branches/249/src/
>
> Affected files:
>  M     chrome/browser/gtk/standard_menus.cc
>
>
> Index: chrome/browser/gtk/standard_menus.cc
> ===================================================================
> --- chrome/browser/gtk/standard_menus.cc        (revision 33833)
> +++ chrome/browser/gtk/standard_menus.cc        (working copy)
> @@ -96,8 +96,6 @@
>     GDK_j, GDK_CONTROL_MASK },
>   { MENU_NORMAL, IDC_MANAGE_EXTENSIONS, IDS_SHOW_EXTENSIONS },
>   { MENU_SEPARATOR },
> -  { MENU_NORMAL, IDC_SYNC_BOOKMARKS, IDS_SYNC_MY_BOOKMARKS_LABEL},
> -  { MENU_SEPARATOR },
>   { MENU_NORMAL, IDC_OPTIONS, IDS_OPTIONS, IDS_PRODUCT_NAME },
>   { MENU_NORMAL, IDC_ABOUT, IDS_ABOUT, IDS_PRODUCT_NAME },
>   { MENU_NORMAL, IDC_HELP_PAGE, IDS_HELP_PAGE, 0, NULL, GDK_F1 },
>
>
>

Expand Messages | Collapse Messages