Issue 467017: Downward drag after mouse-down is now causing bookmark bar folders to open, r...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 467017: Downward drag after mouse-down is now causing bookmark bar folders to open, r... (Closed)

Created:
11 years ago by zel

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Downward drag after mouse-down is now causing bookmark bar folders to open, rather than drag. The bar folder can still be dragged in any other direction. Please note that this change is already reviews in http://codereview.chromium.org/463001, hence TBR field here. I needed to move to a different client to check it in. BUG=9016 TEST=Open bookmark bar. Select folder button and try to drag it down. Observe that now if dragged straight downward, the folder button will open its menu. TBR=sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33805

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -2 lines)			Patch
M	chrome/browser/views/bookmark_bar_view.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/views/bookmark_bar_view.cc	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download
M	chrome/browser/views/toolbar_view.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	views/view.h	View	1	1 chunk	+9 lines, -1 line	0 comments	Download
M	views/view.cc	View	1	1 chunk	+7 lines, -1 line	0 comments	Download