test/cctest/test-debug.cc - Issue 467013003: Add interceptor support for symbols

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-debug.cc

Issue 467013003: Add interceptor support for symbols (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix nits, update test suite Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-debug.cc

diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc

index 5c0b0f392d55435d57effdd6ba082af0c5f85b3d..2573d332f792e737d7686c5f82e92031e0933e84 100644

--- a/test/cctest/test-debug.cc

+++ b/test/cctest/test-debug.cc

@@ -4264,9 +4264,10 @@ static void IndexedEnum(const v8::PropertyCallbackInfo<v8::Array>& info) {

}

-static void NamedGetter(v8::Local<v8::String> name,

+static void NamedGetter(v8::Local<v8::Name> name,

const v8::PropertyCallbackInfo<v8::Value>& info) {

- v8::String::Utf8Value n(name);

+ if (name->IsSymbol()) return;

+ v8::String::Utf8Value n(v8::Local<v8::String>::Cast(name));

if (strcmp(*n, "a") == 0) {

info.GetReturnValue().Set(v8::String::NewFromUtf8(info.GetIsolate(), "AA"));

return;