Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 467013002: Move net.html import down into the modules that use it (Closed)

Created:
6 years, 4 months ago by leviw_travelin_and_unemployed
Modified:
6 years, 4 months ago
Reviewers:
ojan
CC:
ojan, blink-reviews, dsinclair, jochen (gone - plz use gerrit), leviw_travelin_and_unemployed, michaelpg, szager1, teravest
Project:
blink
Visibility:
Public.

Description

Move net.html import down into the modules that use it Avoid importing net.html in the top level and instead have the files that use it importing it themselves. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180123

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Tools/GardeningServer/model/ct-commit-log.html View 1 chunk +1 line, -1 line 0 comments Download
M Tools/GardeningServer/model/tree-status.html View 1 chunk +2 lines, -0 lines 0 comments Download
M Tools/GardeningServer/ui/ct-failure-analyzer.html View 1 chunk +1 line, -0 lines 0 comments Download
M Tools/GardeningServer/ui/ct-sheriff-o-matic.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
leviw_travelin_and_unemployed
6 years, 4 months ago (2014-08-12 23:37:25 UTC) #1
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 4 months ago (2014-08-12 23:58:38 UTC) #2
ojan
lgtm
6 years, 4 months ago (2014-08-12 23:58:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/467013002/1
6 years, 4 months ago (2014-08-13 00:00:43 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 00:03:27 UTC) #5
Message was sent while issue was closed.
Change committed as 180123

Powered by Google App Engine
This is Rietveld 408576698