Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: net/third_party/nss/ssl/ssl.h

Issue 4670004: Change NSS's native auth patch to use PCERT_KEY_CONTEXT instead of HCRYPTPROV on Win (Closed) Base URL: svn://
Patch Set: Rebase to trunk Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/third_party/nss/ssl/ssl.h
diff --git a/net/third_party/nss/ssl/ssl.h b/net/third_party/nss/ssl/ssl.h
index 3515007245e41f809ad34c117167a99ff27a03fb..119ba83034aaf24a2c2c2f3a542581fd554bb8ce 100644
--- a/net/third_party/nss/ssl/ssl.h
+++ b/net/third_party/nss/ssl/ssl.h
@@ -351,8 +351,11 @@ SSL_IMPORT SECStatus SSL_GetClientAuthDataHook(PRFileDesc *fd,
* the client cert, and any following being used for chain
* building
* pRetKey - pointer to native key pointer, for return of key
- * - Windows: pointer to HCRYPTPROV
- * - Mac OS X: pointer to SecKeyRef
+ * - Windows: A PCERT_KEY_CONTEXT, allocated via PORT_Alloc().
wtc 2011/02/04 01:32:16 This should say "A pointer to PCERT_KEY_CONTEXT",
Ryan Sleevi 2011/02/05 04:43:20 Thanks. Here, it is supposed to be a pointer-to-a-
+ * Ownership will be transferred to NSS, which will free
+ * via PORT_Free().
+ * - Mac OS X: A pointer to a SecKeyRef. Ownership will be
+ * transferred to NSS, which will free via CFRelease().
typedef SECStatus (PR_CALLBACK *SSLGetPlatformClientAuthData)(void *arg,
PRFileDesc *fd,

Powered by Google App Engine
This is Rietveld 408576698