Change NSS's native auth patch to use PCERT_KEY_CONTEXT instead of HCRYPTPROV on Win

net/third_party/nss/ssl/ssl.h

Index: net/third_party/nss/ssl/ssl.h
diff --git a/net/third_party/nss/ssl/ssl.h b/net/third_party/nss/ssl/ssl.h
index 3515007245e41f809ad34c117167a99ff27a03fb..119ba83034aaf24a2c2c2f3a542581fd554bb8ce 100644
--- a/net/third_party/nss/ssl/ssl.h
+++ b/net/third_party/nss/ssl/ssl.h
@@ -351,8 +351,11 @@ SSL_IMPORT SECStatus SSL_GetClientAuthDataHook(PRFileDesc *fd,
  *		    the client cert, and any following being used for chain
  *		    building
  *	pRetKey - pointer to native key pointer, for return of key
- *          - Windows: pointer to HCRYPTPROV
- *          - Mac OS X: pointer to SecKeyRef
+ *          - Windows: A PCERT_KEY_CONTEXT, allocated via PORT_Alloc().

[wtc, 2011/02/04 01:32:16]

This should say "A pointer to PCERT_KEY_CONTEXT", right?

Also, you should clarify that it is CERT_KEY_CONTEXT that
is allocated via PORT_Alloc(), in this comment and in the
Description of the CL.

[Ryan Sleevi, 2011/02/05 04:43:20]

Thanks. Here, it is supposed to be a pointer-to-a-PCERT_KEY_CONTEXT, since it
needs to be a pointer-to-a-pointer. The CL description is correct though, in
that it changes from an HCRYPTPROV to a PCERT_KEY_CONTEXT (that is, a pointer to
a CERT_KEY_CONTEXT), so I left that as is.

+ *                     Ownership will be transferred to NSS, which will free
+ *                     via PORT_Free().
+ *          - Mac OS X: A pointer to a SecKeyRef. Ownership will be
+ *                      transferred to NSS, which will free via CFRelease().
  */
 typedef SECStatus (PR_CALLBACK *SSLGetPlatformClientAuthData)(void *arg,
                                 PRFileDesc *fd,