Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 466943002: Remove isolatesBlending from render tree dumps (Closed)

Created:
6 years, 4 months ago by abarth-chromium
Modified:
6 years, 4 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-rendering, Rik, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rosca, rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Remove isolatesBlending from render tree dumps This CL removes the "isolatesBlending" string from render tree dumps. When we compute render tree dumps, this state is not always up-to-date, which means we're getting stale information in the render tree dumps. We don't include other descendant-dependent flags in render tree dumps for this reason. This CL costs us some test coverage, but the appropriate way to regain that test coverage to use reference tests to ensure that the pixels we draw are correctly blended rather than hard-coding internal state from the engine into test results. R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180111

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -49 lines) Patch
M LayoutTests/css3/compositing/mix-blend-mode-isolated-group-1-expected.txt View 1 chunk +15 lines, -15 lines 0 comments Download
M LayoutTests/css3/compositing/mix-blend-mode-isolated-group-2-expected.txt View 1 chunk +15 lines, -15 lines 0 comments Download
M LayoutTests/css3/compositing/mix-blend-mode-isolated-group-3-expected.txt View 1 chunk +15 lines, -15 lines 0 comments Download
M LayoutTests/css3/compositing/mix-blend-mode-simple-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/compositing/mix-blend-mode-simple-text-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTreeAsText.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
6 years, 4 months ago (2014-08-12 21:37:59 UTC) #1
esprehn
Why not do a compositing update before doing a render tree dump? lgtm
6 years, 4 months ago (2014-08-12 22:13:17 UTC) #2
esprehn
Land it!
6 years, 4 months ago (2014-08-12 22:13:35 UTC) #3
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 4 months ago (2014-08-12 22:45:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/466943002/1
6 years, 4 months ago (2014-08-12 22:47:03 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 22:53:07 UTC) #6
Message was sent while issue was closed.
Change committed as 180111

Powered by Google App Engine
This is Rietveld 408576698