Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 466923002: Add expect_tests and testing_support to infra recipe. (Closed)

Created:
6 years, 4 months ago by iannucci
Modified:
6 years, 4 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Project:
tools
Visibility:
Public.

Description

Add expect_tests and testing_support to infra recipe. For more better access :) R=eseidel@chromium.org, stip@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=290190

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M recipes/infra.py View 1 chunk +13 lines, -8 lines 2 comments Download

Messages

Total messages: 12 (0 generated)
iannucci
6 years, 4 months ago (2014-08-12 21:03:40 UTC) #1
ghost stip (do not use)
nuts but lgtm https://chromiumcodereview.appspot.com/466923002/diff/1/recipes/infra.py File recipes/infra.py (right): https://chromiumcodereview.appspot.com/466923002/diff/1/recipes/infra.py#newcode17 recipes/infra.py:17: solution = lambda name, path_infix = ...
6 years, 4 months ago (2014-08-12 21:12:00 UTC) #2
iannucci
The CQ bit was checked by iannucci@chromium.org
6 years, 4 months ago (2014-08-17 17:53:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/466923002/1
6 years, 4 months ago (2014-08-17 17:53:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (1) as 290190
6 years, 4 months ago (2014-08-17 17:55:05 UTC) #5
eseidel
What is this for? Why do we need to modify the defauld "fetch infra" checkout? ...
6 years, 4 months ago (2014-08-18 15:47:40 UTC) #6
iannucci
On 2014/08/18 15:47:40, eseidel wrote: > What is this for? Why do we need to ...
6 years, 4 months ago (2014-08-18 16:56:43 UTC) #7
iannucci
Oops, sent too early. It's so that `fetch infra` gets all of the repos that ...
6 years, 4 months ago (2014-08-18 16:57:26 UTC) #8
eseidel
Sorry, I am confusing recipies. I thought this was the try-job recipe we wrote which ...
6 years, 4 months ago (2014-08-18 16:59:14 UTC) #9
iannucci
On 2014/08/18 16:59:14, eseidel wrote: > Sorry, I am confusing recipies. I thought this was ...
6 years, 4 months ago (2014-08-18 16:59:51 UTC) #10
iannucci
On 2014/08/18 16:59:51, iannucci wrote: > On 2014/08/18 16:59:14, eseidel wrote: > > Sorry, I ...
6 years, 4 months ago (2014-08-18 17:00:08 UTC) #11
iannucci
6 years, 4 months ago (2014-08-18 17:00:47 UTC) #12
Message was sent while issue was closed.
On 2014/08/18 17:00:08, iannucci wrote:
> On 2014/08/18 16:59:51, iannucci wrote:
> > On 2014/08/18 16:59:14, eseidel wrote:
> > > Sorry, I am confusing recipies.  I thought this was the try-job recipe we
> > wrote
> > > which you were modifying to do more than 'fetch infra' did, but only on
the
> > bots
> > > (which seemed bad).  This is the 'fetch infra' recipe instead?
> > 
> > Yes, this is the depot_tools fetch recipe for infra.
> 
> (for humans, not for bots)

((and yes, having them both be called recipes was confusing, though at the time
we thought they'd converge... optimism, eh?))

Powered by Google App Engine
This is Rietveld 408576698