Issue 466873002: Use combined color/coverage attribute when possible in aa rect renderer.

Issue 466873002: Use combined color/coverage attribute when possible in aa rect renderer. (Closed)

Created:
6 years, 4 months ago by bsalomon

Modified:
6 years, 4 months ago

Reviewers:
robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Use combined color/coverage attribute when possible in aa rect renderer. Also restore the is_irect test to detect AA rects that are integer aligned. Committed: https://skia.googlesource.com/skia/+/c30aaa0e40a2957b847910f80665616e0d103d50

Patch Set 1 #

Total comments: 6

Patch Set 2 : also revert removal of irect check #

Patch Set 3 : Update ignored-tests.txt #

Patch Set 4 : rebase #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -20 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
M	src/gpu/GrAARectRenderer.cpp	View	1	8 chunks	+64 lines, -20 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	1 2 3	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

bsalomon

Verifying that perf is restored now, but probably ready for review.

6 years, 4 months ago (2014-08-12 19:42:38 UTC) #1

robertphillips

lgtm https://codereview.chromium.org/466873002/diff/1/src/gpu/GrAARectRenderer.cpp File src/gpu/GrAARectRenderer.cpp (right): https://codereview.chromium.org/466873002/diff/1/src/gpu/GrAARectRenderer.cpp#newcode263 src/gpu/GrAARectRenderer.cpp:263: multiplied ? https://codereview.chromium.org/466873002/diff/1/src/gpu/GrAARectRenderer.cpp#newcode542 src/gpu/GrAARectRenderer.cpp:542: } else { SK_ColorTRANSPARENT ...

6 years, 4 months ago (2014-08-12 19:51:30 UTC) #2

bsalomon

PTAL. It was actually the irect part that had the bigger perf impact, I believe. ...

6 years, 4 months ago (2014-08-12 21:19:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/466873002/60001

6 years, 4 months ago (2014-08-13 14:07:25 UTC) #6

commit-bot: I haz the power

6 years, 4 months ago (2014-08-13 14:15:35 UTC) #7

Message was sent while issue was closed.

Committed patchset #4 (60001) as c30aaa0e40a2957b847910f80665616e0d103d50

Expand Messages | Collapse Messages