Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: tools/gn/secondary/build/config/compiler/BUILD.gn

Issue 46683002: GN Mac build work (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/secondary/build/config/compiler/BUILD.gn
diff --git a/tools/gn/secondary/build/config/compiler/BUILD.gn b/tools/gn/secondary/build/config/compiler/BUILD.gn
index 6174b2e7333dc03c62c6c6e8aad3dfac8ab40341..ef9d61f9f01382faf5a06fee8ead1766705aa43a 100644
--- a/tools/gn/secondary/build/config/compiler/BUILD.gn
+++ b/tools/gn/secondary/build/config/compiler/BUILD.gn
@@ -116,9 +116,7 @@ config("compiler") {
# Clang-specific compiler flags setup.
# ------------------------------------
- # TODO(brettw) these should be clang-only. For now, make it mac-only since
- # that's where we always use clang.
- if (is_mac) { # if (is_clang) {
+ if (is_clang) {
cflags += [
"-fcolor-diagnostics",
]
@@ -301,7 +299,7 @@ config("default_warnings") {
# TODO(brettw) Ones below here should be clang-only when we have a flag
# for it.
- if (is_mac) { #if (is_clang) {
+ if (is_clang) {
cflags += [
"-Wheader-hygiene",

Powered by Google App Engine
This is Rietveld 408576698