Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 466823002: Revert of Rebaseline font tests for Android after r288168 (Closed)

Created:
6 years, 4 months ago by Fabrice (no longer in Chrome)
Modified:
6 years, 4 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Revert of Rebaseline font tests for Android after r288168 (https://codereview.chromium.org/453923002/) Reason for revert: Failure in blink_tests The old files now seem correct. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/18077 Original issue's description: > Rebaseline font tests for Android after r288168 > > - svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults.xhtml > - svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg > - svg/as-background-image/svg-width-100p-as-background.html > - css1/font_properties/font_variant.html > - virtual/antialiasedtext/fast/text/chromium-linux-fontconfig-renderstyle.html > - fast/text/chromium-linux-fontconfig-renderstyle.html > > > TBR=mvanouwerkerk@chromium.org,zerny@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179820 TBR=mvanouwerkerk@chromium.org,zerny@chromium.org,haraken@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180085

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -187 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/android/css1/font_properties/font_variant-expected.png View Binary file 0 comments Download
M LayoutTests/platform/android/css1/font_properties/font_variant-expected.txt View 1 chunk +42 lines, -42 lines 0 comments Download
M LayoutTests/platform/android/fast/text/chromium-linux-fontconfig-renderstyle-expected.png View Binary file 0 comments Download
M LayoutTests/platform/android/fast/text/chromium-linux-fontconfig-renderstyle-expected.txt View 1 chunk +121 lines, -123 lines 0 comments Download
M LayoutTests/platform/android/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png View Binary file 0 comments Download
M LayoutTests/platform/android/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
D LayoutTests/platform/android/svg/as-background-image/svg-width-100p-as-background-expected.png View Binary file 0 comments Download
D LayoutTests/platform/android/svg/as-background-image/svg-width-100p-as-background-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/platform/android/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png View Binary file 0 comments Download
D LayoutTests/platform/android/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Fabrice (no longer in Chrome)
Created Revert of Rebaseline font tests for Android after r288168
6 years, 4 months ago (2014-08-12 16:59:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fdegans@chromium.org/466823002/1
6 years, 4 months ago (2014-08-12 17:00:24 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 17:00:25 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-12 17:00:28 UTC) #4
Michael van Ouwerkerk
Based on the comments in this bug I think this revert is correct: https://code.google.com/p/chromium/issues/detail?id=401954 lgtm
6 years, 4 months ago (2014-08-12 17:03:02 UTC) #5
Michael van Ouwerkerk
The CQ bit was checked by mvanouwerkerk@chromium.org
6 years, 4 months ago (2014-08-12 17:03:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fdegans@chromium.org/466823002/1
6 years, 4 months ago (2014-08-12 17:04:40 UTC) #7
commit-bot: I haz the power
Change committed as 180085
6 years, 4 months ago (2014-08-12 17:07:58 UTC) #8
haraken
6 years, 4 months ago (2014-08-12 23:27:49 UTC) #9
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698