[cleanup] Removed dead code from avatar selection screen.

chrome/browser/resources/chromeos/login/oobe_screen_user_image.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Oobe user image screen implementation.
  */
 
 cr.define('login', function() {
   var UserImagesGrid = options.UserImagesGrid;
@@ skipping 43 matching lines @@
     __proto__: login.Screen.prototype,
 
     /**
      * Currently selected user image index (take photo button is with zero
      * index).
      * @type {number}
      */
     selectedUserImage_: -1,
 
     /**
-     * Indicates if profile picture should be displayed on current screen.
-     */
-    profilePictureEnabled_: false,
-
-    /**
      * URL for profile picture.
      */
     profileImageUrl_: null,
 
     /** @override */
     decorate: function(element) {
       var imageGrid = $('user-image-grid');
       UserImagesGrid.decorate(imageGrid);
 
       // Preview image will track the selected item's URL.
@@ skipping 11 matching lines @@
       imageGrid.addEventListener('phototaken',
                                  this.handlePhotoTaken_.bind(this));
       imageGrid.addEventListener('photoupdated',
                                  this.handlePhotoUpdated_.bind(this));
 
       // Set the title for camera item in the grid.
       imageGrid.setCameraTitles(
           loadTimeData.getString('takePhoto'),
           loadTimeData.getString('photoFromCamera'));
 
-      this.setProfilePictureEnabled_(true);
+      this.profileImageLoading = true;
 
-      this.profileImageLoading = true;
+      // Profile image data (if present).
+      this.profileImage_ = imageGrid.addItem(
+          ButtonImages.PROFILE_PICTURE,           // Image URL.
+          loadTimeData.getString('profilePhoto'), // Title.
+          undefined,                              // Click handler.
+          0,                                      // Position.
+          function(el) {
+            // Custom decorator for Profile image element.
+            var spinner = el.ownerDocument.createElement('div');
+            spinner.className = 'spinner';
+            var spinnerBg = el.ownerDocument.createElement('div');
+            spinnerBg.className = 'spinner-bg';
+            spinnerBg.appendChild(spinner);
+            el.appendChild(spinnerBg);
+            el.id = 'profile-image';
+          });
+      this.profileImage_.type = 'profile';
 
       $('take-photo').addEventListener(
           'click', this.handleTakePhoto_.bind(this));
       $('discard-photo').addEventListener(
           'click', this.handleDiscardPhoto_.bind(this));
 
       // Toggle 'animation' class for the duration of WebKit transition.
       $('flip-photo').addEventListener(
           'click', this.handleFlipPhoto_.bind(this));
       $('user-image-stream-crop').addEventListener(
@@ skipping 44 matching lines @@
 
     /**
      * True if the Profile image is being loaded.
      * @type {boolean}
      */
     get profileImageLoading() {
       return this.profileImageLoading_;
     },
     set profileImageLoading(value) {
       this.profileImageLoading_ = value;
-      $('user-image-screen-main').classList[
-          value ? 'add' : 'remove']('profile-image-loading');
+      $('user-image-screen-main').classList.toggle('profile-image-loading',
+                                                   value);
       if (value)
         announceAccessibleMessage(loadTimeData.getString('syncingPreferences'));
       this.updateProfileImageCaption_();
     },
 
     /**
      * Handles image activation (by pressing Enter).
      * @private
      */
     handleImageActivated_: function() {
@@ skipping 163 matching lines @@
     setCameraPresent_: function(present) {
       $('user-image-grid').cameraPresent = present;
     },
 
     /**
      * Controls the profile image as one of image options.
      * @param {enabled} Whether profile image option should be displayed.
      * @private
      */
     setProfilePictureEnabled_: function(enabled) {
-      if (this.profilePictureEnabled_ == enabled)
-        return;
-      this.profilePictureEnabled_ = enabled;
       var imageGrid = $('user-image-grid');
       if (enabled) {
-        var url = ButtonImages.PROFILE_PICTURE;
-        if (!this.profileImageLoading && this.profileImageUrl_ !== null) {
-          url = this.profileImageUrl_;
-        }
-        // Profile image data (if present).
-        this.profileImage_ = imageGrid.addItem(
-            url,                                    // Image URL.
-            loadTimeData.getString('profilePhoto'), // Title.
-            undefined,                              // Click handler.
-            0,                                      // Position.
-            this.profileImageLoading ? function(el) {
-              // Custom decorator for Profile image element.
-              var spinner = el.ownerDocument.createElement('div');
-              spinner.className = 'spinner';
-              var spinnerBg = el.ownerDocument.createElement('div');
-              spinnerBg.className = 'spinner-bg';
-              spinnerBg.appendChild(spinner);
-              el.appendChild(spinnerBg);
-              el.id = 'profile-image';
-            } : undefined);
-        this.profileImage_.type = 'profile';
       } else {
         imageGrid.removeItem(this.profileImage_);
       }
     },
 
     /**
      * Appends default images to the image grid. Should only be called once.
      * @param {Array.<{url: string, author: string, website: string}>} images
      *   An array of default images data, including URL, author and website.
      * @private
@@ skipping 80 matching lines @@
     UserImageScreen[name] = function(value) {
       $('user-image')[name + '_'](value);
     };
   });
 
   return {
     UserImageScreen: UserImageScreen
   };
 });