Issue 466793002: [cleanup] Removed dead code from avatar selection screen.

Issue 466793002: [cleanup] Removed dead code from avatar selection screen. (Closed)

Created:
6 years, 4 months ago by dzhioev (left Google)

Modified:
6 years, 4 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, arv+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[cleanup] Removed dead code from avatar selection screen. Params "user_id" and "profile_picture_enabled" were not used so I removed them and related code. Also one usage of GetProfileByUserUnsafe eliminated. BUG=361528 TEST=browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289661

Patch Set 1 #

Total comments: 4

Patch Set 2 : Comments addressed. Fixed regression. #

Patch Set 3 : Rebased. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -110 lines)			Patch
M	chrome/browser/chromeos/login/screens/user_image_screen.h	View		2 chunks	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/login/screens/user_image_screen.cc	View	1	5 chunks	+11 lines, -43 lines	0 comments	Download
M	chrome/browser/chromeos/login/screens/user_image_screen_actor.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.cc	View	1	1 chunk	+1 line, -14 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe_screen_user_image.css	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe_screen_user_image.js	View	1	4 chunks	+20 lines, -33 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

lgtm https://codereview.chromium.org/466793002/diff/1/chrome/browser/chromeos/login/screens/user_image_screen.cc File chrome/browser/chromeos/login/screens/user_image_screen.cc (left): https://codereview.chromium.org/466793002/diff/1/chrome/browser/chromeos/login/screens/user_image_screen.cc#oldcode229 chrome/browser/chromeos/login/screens/user_image_screen.cc:229: notification_registrar_.Remove(this, What about this code of removing notification ...

6 years, 4 months ago (2014-08-13 16:30:29 UTC) #2

dzhioev (left Google)

https://codereview.chromium.org/466793002/diff/1/chrome/browser/chromeos/login/screens/user_image_screen.cc File chrome/browser/chromeos/login/screens/user_image_screen.cc (left): https://codereview.chromium.org/466793002/diff/1/chrome/browser/chromeos/login/screens/user_image_screen.cc#oldcode229 chrome/browser/chromeos/login/screens/user_image_screen.cc:229: notification_registrar_.Remove(this, On 2014/08/13 16:30:29, Nikita Kostylev wrote: > What ...

6 years, 4 months ago (2014-08-13 18:06:42 UTC) #3

dzhioev (left Google)

The CQ bit was checked by dzhioev@chromium.org

6 years, 4 months ago (2014-08-14 13:46:08 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/466793002/40001

6 years, 4 months ago (2014-08-14 13:48:29 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-14 19:01:41 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (40001) as 289661

Expand Messages | Collapse Messages