Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Unified Diff: Source/core/frame/ConsoleBase.h

Issue 466753002: DevTools: Do not push to frontend messages from worker while it is alive (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address vsevik's comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/ConsoleBase.h
diff --git a/Source/core/frame/ConsoleBase.h b/Source/core/frame/ConsoleBase.h
index 1e88095f58642967a93c0a79d92d5a151ae17f66..a2f27565457e898cd754c802525b0984061c232b 100644
--- a/Source/core/frame/ConsoleBase.h
+++ b/Source/core/frame/ConsoleBase.h
@@ -71,13 +71,13 @@ public:
void groupCollapsed(ScriptState*, PassRefPtrWillBeRawPtr<ScriptArguments>);
void groupEnd();
+ virtual void reportMessageToClient(MessageLevel, const String& message, PassRefPtrWillBeRawPtr<ScriptCallStack>) = 0;
vsevik 2014/08/12 15:46:07 revert this
sergeyv 2014/08/12 16:00:58 Done.
+
virtual void trace(Visitor*) { }
virtual ~ConsoleBase();
-
protected:
virtual ExecutionContext* context() = 0;
- virtual void reportMessageToClient(MessageLevel, const String& message, PassRefPtrWillBeRawPtr<ScriptCallStack>) = 0;
private:
void internalAddMessage(MessageType, MessageLevel, ScriptState*, PassRefPtrWillBeRawPtr<ScriptArguments>, bool acceptNoArguments = false, bool printTrace = false);

Powered by Google App Engine
This is Rietveld 408576698