Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: Source/core/frame/FrameConsole.h

Issue 466753002: DevTools: Do not push to frontend messages from worker while it is alive (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address vsevik's comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 22 matching lines...) Expand all
33 #include "core/frame/ConsoleTypes.h" 33 #include "core/frame/ConsoleTypes.h"
34 #include "platform/heap/Handle.h" 34 #include "platform/heap/Handle.h"
35 #include "wtf/Forward.h" 35 #include "wtf/Forward.h"
36 #include "wtf/PassOwnPtr.h" 36 #include "wtf/PassOwnPtr.h"
37 37
38 namespace blink { 38 namespace blink {
39 39
40 class ConsoleMessage; 40 class ConsoleMessage;
41 class FrameHost; 41 class FrameHost;
42 class ScriptCallStack; 42 class ScriptCallStack;
43 class WorkerGlobalScopeProxy;
43 44
44 // FrameConsole takes per-frame console messages and routes them up through the FrameHost to the ChromeClient and Inspector. 45 // FrameConsole takes per-frame console messages and routes them up through the FrameHost to the ChromeClient and Inspector.
45 // It's meant as an abstraction around ChromeClient calls and the way that Blink core/ can add messages to the console. 46 // It's meant as an abstraction around ChromeClient calls and the way that Blink core/ can add messages to the console.
46 class FrameConsole FINAL { 47 class FrameConsole FINAL {
47 public: 48 public:
48 static PassOwnPtr<FrameConsole> create(LocalFrame& frame) { return adoptPtr( new FrameConsole(frame)); } 49 static PassOwnPtr<FrameConsole> create(LocalFrame& frame) { return adoptPtr( new FrameConsole(frame)); }
49 50
50 void addMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>); 51 void addMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>);
52 void workerGlobalScopeTerminated(WorkerGlobalScopeProxy*);
53
51 static String formatStackTraceString(const String& originalMessage, PassRefP trWillBeRawPtr<ScriptCallStack>); 54 static String formatStackTraceString(const String& originalMessage, PassRefP trWillBeRawPtr<ScriptCallStack>);
52 55
53 static void mute(); 56 static void mute();
54 static void unmute(); 57 static void unmute();
55 58
56 private: 59 private:
57 explicit FrameConsole(LocalFrame&); 60 explicit FrameConsole(LocalFrame&);
58 61
59 LocalFrame& m_frame; 62 LocalFrame& m_frame;
60 }; 63 };
61 64
62 } // namespace blink 65 } // namespace blink
63 66
64 #endif // FrameConsole_h 67 #endif // FrameConsole_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698