DevTools: Show doc context menu items for matching methods on all objects

Source/devtools/front_end/documentation/DocumentationView.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @extends {WebInspector.VBox}
  */
 WebInspector.DocumentationView = function()
 {
     WebInspector.VBox.call(this);
 }
 
 /**
- * @param {string} searchTerm
+ * @param {string} searchURL

[apavlov, 2014/08/12 12:54:16]

just "url"

[semeny, 2014/08/12 14:27:59]

Done.

  */
-WebInspector.DocumentationView.showSearchTerm = function(searchTerm)
+WebInspector.DocumentationView.showSearchURL = function(searchURL)

[apavlov, 2014/08/12 12:54:17]

showDocumentationURL() ?

[semeny, 2014/08/12 14:27:59]

Done.

 {
     if (!WebInspector.DocumentationView._view)
         WebInspector.DocumentationView._view = new WebInspector.DocumentationView();
     var view = WebInspector.DocumentationView._view;
     WebInspector.inspectorView.showCloseableViewInDrawer("documentation", WebInspector.UIString("Documentation"), view);
 }
 
 WebInspector.DocumentationView.prototype = {
     __proto__: WebInspector.VBox.prototype
 }
@@ skipping 15 matching lines @@
     appendApplicableItems: function(event, contextMenu, target)
     {
         if (!(target instanceof WebInspector.CodeMirrorTextEditor))
             return;
         var textEditor = /** @type {!WebInspector.CodeMirrorTextEditor} */ (target);
         var selection = textEditor.selection();
         if (!selection || selection.isEmpty() || selection.startLine !== selection.endLine)
             return;
         var selectedText = textEditor.copyRange(selection);
         var urlProvider = new WebInspector.DocumentationURLProvider();
-        var itemPath = urlProvider.itemPath(selectedText);
-        if (!itemPath)
-            return;
-        contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Show documentation" : "Show Documentation"), WebInspector.DocumentationView.showSearchTerm.bind(null, selectedText));
+        var possiblePaths = urlProvider.itemPath(selectedText);
+        for (var i = 0; i < possiblePaths.length; i++) {

[apavlov, 2014/08/12 12:54:16]

we prefer the pre-increment across the code: ++i

[semeny, 2014/08/12 14:27:59]

Done.

+            var contextMenuItemTitle = WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Show documentation for " + possiblePaths[i].name : "Show Documentation for "  + possiblePaths[i].name);

[yurys, 2014/08/12 12:50:00]

Please use string sunstitution:  WebInspector.UIString("Show documentation for
%s", ...)

[apavlov, 2014/08/12 12:54:17]

This is a wrong way to use UIString. You should use the string formatting:

var formatString = WebInspector.useLowerCaseMenuTitles() ? "Show documentation
for '%s'" : "Show Documentation for '%s'";
var contextMenuItemTitle = WebInspector.UIString(formatString,
possiblePaths[i].name);

[semeny, 2014/08/12 14:27:59]

Done.

+            contextMenu.appendItem(contextMenuItemTitle, WebInspector.DocumentationView.showSearchURL.bind(null, possiblePaths[i].url));

[apavlov, 2014/08/12 12:54:17]

We seem to have agreed on having a submenu, not on a series of top-level items,
IIRC?

This should look like this:

Show documentation for 'remove'
    Array.prototype.remove
    Element.prototype.remove

[semeny, 2014/08/12 14:27:59]

Done.

+        }
     }
 }