Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1941)

Issue 466733004: Update tools for use of picture stats in GPU optimization decision (Closed)

Created:
6 years, 4 months ago by robertphillips
Modified:
6 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Update tools for use of picture stats in GPU optimization decision Committed: https://skia.googlesource.com/skia/+/e94707505e9007c05f67d813bdb2b6eccaf96c06

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M tools/bench_pictures_main.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/render_pictures_main.cpp View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
robertphillips
6 years, 4 months ago (2014-08-12 15:41:01 UTC) #1
bsalomon
Why b_p and not nanobench? I think the numbers out of nb are more reliable.
6 years, 4 months ago (2014-08-12 16:14:35 UTC) #2
robertphillips
Mainly b.c. that's what I've been using. I would also have to add the following ...
6 years, 4 months ago (2014-08-12 16:29:16 UTC) #3
bsalomon
On 2014/08/12 16:29:16, robertphillips wrote: > Mainly b.c. that's what I've been using. I would ...
6 years, 4 months ago (2014-08-12 17:00:49 UTC) #4
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 4 months ago (2014-08-12 17:03:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/466733004/1
6 years, 4 months ago (2014-08-12 17:04:09 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 17:12:46 UTC) #7
Message was sent while issue was closed.
Change committed as e94707505e9007c05f67d813bdb2b6eccaf96c06

Powered by Google App Engine
This is Rietveld 408576698