Source/modules/serviceworkers/ServiceWorkerRegistration.cpp - Issue 466723002: ServiceWorker: Enable ServiceWorkerRegistration and update layout tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

Issue 466723002: ServiceWorker: Enable ServiceWorkerRegistration and update layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@updatefound

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

diff --git a/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp b/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

index bbf5d0df242eb4677f782479fa46584b90a02544..6f746732ebf9439dfbefac2ffc957e3ebfd21c05 100644

--- a/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

+++ b/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

@@ -22,11 +22,7 @@ namespace blink {

class UndefinedValue {

public:

-#ifdef DISABLE_SERVICE_WORKER_REGISTRATION

- typedef WebServiceWorker WebType;

-#else

typedef WebServiceWorkerRegistration WebType;

-#endif

static V8UndefinedType take(ScriptPromiseResolver* resolver, WebType* registration)

{

ASSERT(!registration); // Anything passed here will be leaked.

« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerContainer.cpp ('k') | public/platform/WebServiceWorkerProvider.h » ('j') | no next file with comments »