Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: LayoutTests/http/tests/serviceworker/registration.html

Issue 466723002: ServiceWorker: Enable ServiceWorkerRegistration and update layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@updatefound
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/serviceworker/registration.html
diff --git a/LayoutTests/http/tests/serviceworker/registration.html b/LayoutTests/http/tests/serviceworker/registration.html
index 0732ade2c6ab6af7f2e7f0e2aa6fc8c664c91949..512edfbb008cb4dee148dc887c8101a721ff06cb 100644
--- a/LayoutTests/http/tests/serviceworker/registration.html
+++ b/LayoutTests/http/tests/serviceworker/registration.html
@@ -12,8 +12,8 @@
'resources/registration-worker.js',
{scope: scope}
).then(
- t.step_func(function(worker) {
- assert_true(worker instanceof ServiceWorker,
+ t.step_func(function(registration) {
+ assert_true(registration instanceof ServiceWorkerRegistration,
'Successfully registered.');
service_worker_unregister_and_done(t, scope);
}),
@@ -31,7 +31,7 @@
'resources/registration-worker.js',
{scope: 'http://example.com/'}
).then(
- t.step_func(function(worker) {
+ t.step_func(function(registration) {
assert_unreached('Registration scope outside domain should fail.');
}),
t.step_func(function(reason) {
@@ -49,7 +49,7 @@
navigator.serviceWorker.register(
'http://example.com/worker.js'
).then(
- t.step_func(function(worker) {
+ t.step_func(function(registration) {
assert_unreached('Registration script outside domain should fail.');
}),
t.step_func(function(reason) {
@@ -67,7 +67,7 @@
navigator.serviceWorker.register(
'resources/no-such-worker.js'
).then(
- t.step_func(function(worker) {
+ t.step_func(function(registration) {
assert_unreached('Registration of non-existent script should fail.');
}),
t.step_func(function(reason) {
« no previous file with comments | « LayoutTests/http/tests/serviceworker/ready.html ('k') | LayoutTests/http/tests/serviceworker/registration-end-to-end.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698