LayoutTests/http/tests/serviceworker/registration-end-to-end.html - Issue 466723002: ServiceWorker: Enable ServiceWorkerRegistration and update layout tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/serviceworker/registration-end-to-end.html

Issue 466723002: ServiceWorker: Enable ServiceWorkerRegistration and update layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@updatefound

Patch Set: apply horo@'s patch (PatchSet 28 on https://codereview.chromium.org/468753003/) Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/serviceworker/chromium/service-worker-gc.html ('K') | « LayoutTests/http/tests/serviceworker/registration.html ('k') | LayoutTests/http/tests/serviceworker/registration-events.html » ('j') | LayoutTests/http/tests/serviceworker/resources/fetch-mixed-content-iframe.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/serviceworker/registration-end-to-end.html

diff --git a/LayoutTests/http/tests/serviceworker/registration-end-to-end.html b/LayoutTests/http/tests/serviceworker/registration-end-to-end.html

index 13c49c7d82988088a3faa64d638f569490344a24..aa2a89d6690de5ea72fbb9c143066ecda334189e 100644

--- a/LayoutTests/http/tests/serviceworker/registration-end-to-end.html

+++ b/LayoutTests/http/tests/serviceworker/registration-end-to-end.html

@@ -22,7 +22,12 @@ t.step(function() {

};

service_worker_unregister_and_register(

- t, 'resources/end-to-end-worker.js', scope).then(t.step_func(onRegister));

+ t, 'resources/end-to-end-worker.js', scope)

+ .then(t.step_func(function(registration) {

+ return wait_for_update(t, registration);

+ }))

+ .then(t.step_func(onRegister))

+ .catch(unreached_rejection(t));

function sendMessagePort(worker, from) {

var messageChannel = new MessageChannel();