LayoutTests/http/tests/serviceworker/chromium/registration-stress.html - Issue 466723002: ServiceWorker: Enable ServiceWorkerRegistration and update layout tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/serviceworker/chromium/registration-stress.html

Issue 466723002: ServiceWorker: Enable ServiceWorkerRegistration and update layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@updatefound

Patch Set: apply horo@'s patch (PatchSet 25 on https://codereview.chromium.org/468753003/) Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/active.html ('k') | LayoutTests/http/tests/serviceworker/chromium/service-worker-gc.html » ('j') | LayoutTests/http/tests/serviceworker/chromium/service-worker-gc.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/serviceworker/chromium/registration-stress.html

diff --git a/LayoutTests/http/tests/serviceworker/chromium/registration-stress.html b/LayoutTests/http/tests/serviceworker/chromium/registration-stress.html

index cf904e8156bd5e181c64da01deb6e9a81d09f47c..62a5a7f13a05c15d47657cd710fd2a3ef6d90934 100644

--- a/LayoutTests/http/tests/serviceworker/chromium/registration-stress.html

+++ b/LayoutTests/http/tests/serviceworker/chromium/registration-stress.html

@@ -24,7 +24,7 @@ async_test(function(t) {

}

Promise.all(register_promises)

- .then(step(function(workers) {

+ .then(step(function(registrations) {

var unregister_promises = [];

for (var i = 0; i < number_of_workers; i++) {

var scope = i;

@@ -34,7 +34,10 @@ async_test(function(t) {

}

return Promise.all(unregister_promises);

}))

- .then(step(function() { t.done(); }))

+ .then(step(function() {

+ gc();

falken 2014/08/14 04:46:11 Can you add a comment explaining why we're calling

horo 2014/08/14 07:11:46 removed

+ t.done();

+ }))

.catch(unreached_rejection(t));

}, 'Registration: stress test');