Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 466713002: Credential manager: Fixing missing stub declarations. (Closed)

Created:
6 years, 4 months ago by Mike West
Modified:
6 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Credential manager: Fixing missing stub declarations. https://src.chromium.org/viewvc/blink?view=rev&revision=180040 introduced the WebCredentialManager interface, but neglected to create default constructor/destructor implementations. This trivial patch corrects that oversight. BUG=400674 TBR=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M public/platform/WebCredentialManager.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mike West
TBRing you tkent@. Sorry I missed this on the first pass.
6 years, 4 months ago (2014-08-12 11:27:55 UTC) #1
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 4 months ago (2014-08-12 11:27:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/466713002/1
6 years, 4 months ago (2014-08-12 11:28:17 UTC) #3
commit-bot: I haz the power
Change committed as 180067
6 years, 4 months ago (2014-08-12 12:10:51 UTC) #4
tkent
6 years, 4 months ago (2014-08-12 14:02:15 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698