Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1928)

Unified Diff: Source/devtools/front_end/network/NetworkPanel.js

Issue 466703002: DevTools: get rid of Element.prototype.removeMatchingStyleClasses (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/network/NetworkPanel.js
diff --git a/Source/devtools/front_end/network/NetworkPanel.js b/Source/devtools/front_end/network/NetworkPanel.js
index 96521fb338d43ff20876d949e5eea6e157687abe..48dd23aafae0865a5c8ce7f1883c8049c97b1b66 100644
--- a/Source/devtools/front_end/network/NetworkPanel.js
+++ b/Source/devtools/front_end/network/NetworkPanel.js
@@ -2502,6 +2502,7 @@ WebInspector.NetworkDataGridNode = function(parentView, request)
this._linkifier = new WebInspector.Linkifier();
this._isFilteredOut = true;
this._isMatchingSearchQuery = false;
+ this._type = null;
}
WebInspector.NetworkDataGridNode.prototype = {
@@ -2522,10 +2523,12 @@ WebInspector.NetworkDataGridNode.prototype = {
var element = this._element;
element.classList.toggle("network-error-row", this._isFailed());
element.classList.toggle("resource-cached", this._request.cached);
- var typeClassName = "network-type-" + this._request.type.name();
- if (!element.classList.contains(typeClassName)) {
- element.removeMatchingStyleClasses("network-type-\\w+");
- element.classList.add(typeClassName);
+ var type = this._request.type.name();
+ if (type != this._type) {
+ if (this._type)
+ element.classList.remove(this._type);
+ this._type = type;
+ element.classList.add(this._type);
}
WebInspector.SortableDataGridNode.prototype.createCells.call(this);
« no previous file with comments | « no previous file | Source/devtools/front_end/networkLogView.css » ('j') | Source/devtools/front_end/networkLogView.css » ('J')

Powered by Google App Engine
This is Rietveld 408576698