DevTools: get rid of Element.prototype.removeMatchingStyleClasses

DevTools: get rid of Element.prototype.removeMatchingStyleClasses

This method encourages className crafting and runs unexpectedly long.

BUG=316092
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180163

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180172

[apavlov, 2014-08-12 09:45:32]

lgtm with a comment

https://codereview.chromium.org/466703002/diff/1/Source/devtools/front_end/ne...
File Source/devtools/front_end/networkLogView.css (right):

https://codereview.chromium.org/466703002/diff/1/Source/devtools/front_end/ne...
Source/devtools/front_end/networkLogView.css:172: .network-log-grid.data-grid
.script .icon {
aren't these shortened class names too general? Could we perhaps add the
"network-type" class to the same element to provide better filtering? Like,
.network-log-grid.data-grid .network-type.script .icon

[eustas, 2014-08-12 11:33:38]

https://codereview.chromium.org/466703002/diff/1/Source/devtools/front_end/ne...
File Source/devtools/front_end/networkLogView.css (right):

https://codereview.chromium.org/466703002/diff/1/Source/devtools/front_end/ne...
Source/devtools/front_end/networkLogView.css:172: .network-log-grid.data-grid
.script .icon {
On 2014/08/12 09:45:32, apavlov wrote:
> aren't these shortened class names too general? Could we perhaps add the
> "network-type" class to the same element to provide better filtering? Like,
> .network-log-grid.data-grid .network-type.script .icon

You are right. But I think it would be better to contract .icon with type (e.g.
.icon.script).

I'll ping you when I update patch.

[eustas, 2014-08-13 08:20:17]

PTAL

[apavlov, 2014-08-13 08:25:16]

The CQ bit was checked by apavlov@chromium.org

[apavlov, 2014-08-13 08:25:16]

lgtm

[commit-bot: I haz the power, 2014-08-13 08:25:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eustas@chromium.org/466703002/40001

[commit-bot: I haz the power, 2014-08-13 09:34:49]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/19599)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22486)

[eustas, 2014-08-13 09:44:12]

The CQ bit was checked by eustas@chromium.org

[commit-bot: I haz the power, 2014-08-13 09:44:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eustas@chromium.org/466703002/60001

[commit-bot: I haz the power, 2014-08-13 10:50:40]

Change committed as 180163

[eustas, 2014-08-13 13:47:57]

The CQ bit was checked by eustas@chromium.org

[commit-bot: I haz the power, 2014-08-13 13:48:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eustas@chromium.org/466703002/80001

[commit-bot: I haz the power, 2014-08-13 13:48:49]

Committed patchset #5 (80001) as 180172