ui/app_list/views/app_list_main_view.h - Issue 466693002: Fix app list DCHECKs getting hit when model updates occur during dragging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/views/app_list_main_view.h

Issue 466693002: Fix app list DCHECKs getting hit when model updates occur during dragging (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add test comment Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/app_list/views/app_list_main_view.h

diff --git a/ui/app_list/views/app_list_main_view.h b/ui/app_list/views/app_list_main_view.h

index 15fdf064daaf9ebdd21915b2d0117d44241ac2f2..b45559dbb11c7bcf8e5a8b38c779b7e3351d0aca 100644

--- a/ui/app_list/views/app_list_main_view.h

+++ b/ui/app_list/views/app_list_main_view.h

@@ -101,6 +101,7 @@ class APP_LIST_EXPORT AppListMainView : public views::View,

virtual void GetShortcutPathForApp(

const std::string& app_id,

const base::Callback<void(const base::FilePath&)>& callback) OVERRIDE;

+ virtual void CancelDragInActiveFolder() OVERRIDE;

// Overridden from SearchBoxViewDelegate:

virtual void QueryChanged(SearchBoxView* sender) OVERRIDE;

« no previous file with comments | « no previous file | ui/app_list/views/app_list_main_view.cc » ('j') | no next file with comments »